package com.stoutner.privacybrowser;
-import android.app.Activity;
+import android.annotation.SuppressLint;
import android.app.Dialog;
-import android.app.DialogFragment;
+import android.content.Context;
import android.content.DialogInterface;
import android.database.Cursor;
import android.graphics.Bitmap;
import android.graphics.BitmapFactory;
-import android.graphics.drawable.BitmapDrawable;
-import android.graphics.drawable.Drawable;
import android.os.Bundle;
// If we don't use `android.support.v7.app.AlertDialog` instead of `android.app.AlertDialog` then the dialog will be covered by the keyboard.
+import android.support.annotation.NonNull;
import android.support.v7.app.AlertDialog;
+// We have to use `AppCompatDialogFragment` instead of `DialogFragment` or an error is produced on API <=22.
+import android.support.v7.app.AppCompatDialogFragment;
import android.view.KeyEvent;
import android.view.View;
import android.view.WindowManager;
import android.widget.EditText;
import android.widget.ImageView;
-public class EditBookmark extends DialogFragment {
+public class EditBookmark extends AppCompatDialogFragment {
// The public interface is used to send information back to the parent activity.
public interface EditBookmarkListener {
- void onCancelEditBookmark(DialogFragment dialogFragment);
-
- void onSaveEditBookmark(DialogFragment dialogFragment);
+ void onSaveEditBookmark(AppCompatDialogFragment dialogFragment);
}
// `editBookmarkListener` is used in `onAttach()` and `onCreateDialog()`
private EditBookmarkListener editBookmarkListener;
- public void onAttach(Activity parentActivity) {
- super.onAttach(parentActivity);
+ public void onAttach(Context context) {
+ super.onAttach(context);
- // Get a handle for `EditBookmarkListener` from `parentActivity`.
+ // Get a handle for `EditBookmarkListener` from `context`.
try {
- editBookmarkListener = (EditBookmarkListener) parentActivity;
+ editBookmarkListener = (EditBookmarkListener) context;
} catch(ClassCastException exception) {
- throw new ClassCastException(parentActivity.toString() + " must implement EditBookmarkListener.");
+ throw new ClassCastException(context.toString() + " must implement EditBookmarkListener.");
}
}
+ // `@SuppressLing("InflateParams")` removes the warning about using `null` as the parent view group when inflating the `AlertDialog`.
+ @SuppressLint("InflateParams")
@Override
+ @NonNull
public Dialog onCreateDialog(Bundle savedInstanceState) {
// Get a long array with the the databaseId of the selected bookmark and convert it to an `int`.
- long[] selectedBookmarkLongArray = BookmarksActivity.bookmarksListView.getCheckedItemIds();
+ long[] selectedBookmarkLongArray = BookmarksActivity.checkedItemIds;
int selectedBookmarkDatabaseId = (int) selectedBookmarkLongArray[0];
// Get a `Cursor` with the specified bookmark and move it to the first position.
dialogBuilder.setNegativeButton(R.string.cancel, new Dialog.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
- // Return the `DialogFragment` to the parent activity on cancel.
- editBookmarkListener.onCancelEditBookmark(EditBookmark.this);
+ // Do nothing. The `AlertDialog` will close automatically.
}
});
// Create an `AlertDialog` from the `AlertDialog.Builder`.
final AlertDialog alertDialog = dialogBuilder.create();
- // Show the keyboard when the `Dialog` is displayed on the screen.
+ // Remove the warning below that `setSoftInputMode` might produce `java.lang.NullPointerException`.
+ assert alertDialog.getWindow() != null;
+
+ // Show the keyboard when `alertDialog` is displayed on the screen.
alertDialog.getWindow().setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE);
// We need to show the `AlertDialog` before we can modify items in the layout.
// Allow the `enter` key on the keyboard to save the bookmark from `edit_bookmark_name_edittext`.
bookmarkNameEditText.setOnKeyListener(new View.OnKeyListener() {
+ @Override
public boolean onKey(View v, int keyCode, KeyEvent event) {
- // If the event is a key-down on the "enter" button, select the PositiveButton `Save`.
+ // If the event is an `ACTION_DOWN` on the `enter` key, save the bookmark.
if ((event.getAction() == KeyEvent.ACTION_DOWN) && (keyCode == KeyEvent.KEYCODE_ENTER)) {
- // Trigger `editBookmarkListener` and return the DialogFragment to the parent activity.
+ // Trigger `onSaveEditBookmark()` and return the `DialogFragment` to the parent activity.
editBookmarkListener.onSaveEditBookmark(EditBookmark.this);
// Manually dismiss `alertDialog`.
alertDialog.dismiss();