X-Git-Url: https://gitweb.stoutner.com/?a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fjava%2Fcom%2Fstoutner%2Fprivacybrowser%2FEditBookmarkFolder.java;h=218023fd9dff1a15d7f8122f3fb136eab3af7afa;hb=bc6574b86391ed9c731835c18de7bd0a10de19f8;hp=c27b963dc3f7436ed53cc8b5457fe34a1aa41faf;hpb=c4ad9f457f41cbc86391e0099629cd94a235258a;p=PrivacyBrowserAndroid.git diff --git a/app/src/main/java/com/stoutner/privacybrowser/EditBookmarkFolder.java b/app/src/main/java/com/stoutner/privacybrowser/EditBookmarkFolder.java index c27b963d..218023fd 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/EditBookmarkFolder.java +++ b/app/src/main/java/com/stoutner/privacybrowser/EditBookmarkFolder.java @@ -19,9 +19,10 @@ package com.stoutner.privacybrowser; -import android.app.Activity; +import android.annotation.SuppressLint; import android.app.Dialog; import android.app.DialogFragment; +import android.content.Context; import android.content.DialogInterface; import android.database.Cursor; import android.graphics.Bitmap; @@ -38,29 +39,29 @@ import android.widget.ImageView; public class EditBookmarkFolder extends DialogFragment { // The public interface is used to send information back to the parent activity. public interface EditBookmarkFolderListener { - void onCancelEditBookmarkFolder(DialogFragment dialogFragment); - void onSaveEditBookmarkFolder(DialogFragment dialogFragment); } // `editFolderListener` is used in `onAttach()` and `onCreateDialog`. private EditBookmarkFolderListener editBookmarkFolderListener; - public void onAttach(Activity parentActivity) { - super.onAttach(parentActivity); + public void onAttach(Context context) { + super.onAttach(context); // Get a handle for `EditFolderListener` from `parentActivity`. try { - editBookmarkFolderListener = (EditBookmarkFolderListener) parentActivity; + editBookmarkFolderListener = (EditBookmarkFolderListener) context; } catch(ClassCastException exception) { - throw new ClassCastException(parentActivity.toString() + " must implement EditBookmarkFolderListener."); + throw new ClassCastException(context.toString() + " must implement EditBookmarkFolderListener."); } } + // `@SuppressLing("InflateParams")` removes the warning about using `null` as the parent view group when inflating the `AlertDialog`. + @SuppressLint("InflateParams") @Override public Dialog onCreateDialog(Bundle savedInstanceState) { // Get a long array with the the databaseId of the selected bookmark and convert it to an `int`. - long[] selectedBookmarkLongArray = BookmarksActivity.bookmarksListView.getCheckedItemIds(); + long[] selectedBookmarkLongArray = BookmarksActivity.checkedItemIds; int selectedBookmarkDatabaseId = (int) selectedBookmarkLongArray[0]; // Get a `Cursor` with the specified bookmark and move it to the first position. @@ -77,8 +78,7 @@ public class EditBookmarkFolder extends DialogFragment { dialogBuilder.setNegativeButton(R.string.cancel, new Dialog.OnClickListener() { @Override public void onClick(DialogInterface dialog, int which) { - // Return the `DialogFragment` to the parent activity on cancel. - editBookmarkFolderListener.onCancelEditBookmarkFolder(EditBookmarkFolder.this); + // Do nothing. The `AlertDialog` will close automatically. } }); @@ -95,6 +95,9 @@ public class EditBookmarkFolder extends DialogFragment { // Create an `AlertDialog` from the `AlertDialog.Builder`. final AlertDialog alertDialog = dialogBuilder.create(); + // Remove the warning below that `setSoftInputMode` might produce `java.lang.NullPointerException`. + assert alertDialog.getWindow() != null; + // Show the keyboard when the `Dialog` is displayed on the screen. alertDialog.getWindow().setSoftInputMode(WindowManager.LayoutParams.SOFT_INPUT_STATE_ALWAYS_VISIBLE); @@ -111,9 +114,9 @@ public class EditBookmarkFolder extends DialogFragment { currentIconImageView.setImageBitmap(currentIconBitmap); // Get a `Bitmap` of the favorite icon from `MainWebViewActivity` and display it in `edit_folder_web_page_favorite_icon`. - ImageView webPageFavoriteIcon = (ImageView) alertDialog.findViewById(R.id.edit_folder_web_page_favorite_icon); - assert webPageFavoriteIcon != null; // Remove the warning below that `webPageFavoriteIcon` might be null. - webPageFavoriteIcon.setImageBitmap(MainWebViewActivity.favoriteIcon); + ImageView webPageFavoriteIconImageView = (ImageView) alertDialog.findViewById(R.id.edit_folder_web_page_favorite_icon); + assert webPageFavoriteIconImageView != null; // Remove the warning below that `webPageFavoriteIcon` might be null. + webPageFavoriteIconImageView.setImageBitmap(MainWebViewActivity.favoriteIcon); // Load the text for `edit_folder_name_edittext`. EditText folderNameEditText = (EditText) alertDialog.findViewById(R.id.edit_folder_name_edittext);