X-Git-Url: https://gitweb.stoutner.com/?a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fjava%2Fcom%2Fstoutner%2Fprivacybrowser%2FSettingsFragment.java;h=60e250b2241f0337f86251cf64b8e4d27ba13fe2;hb=b36f8bd357e28072bd7c810bb3ae47e4e0b20acc;hp=38463427425875c55dbeb7f8c4c36a62a03d2e99;hpb=4a527702ad11865c2a53b01c398b507cd488276c;p=PrivacyBrowserAndroid.git diff --git a/app/src/main/java/com/stoutner/privacybrowser/SettingsFragment.java b/app/src/main/java/com/stoutner/privacybrowser/SettingsFragment.java index 38463427..60e250b2 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/SettingsFragment.java +++ b/app/src/main/java/com/stoutner/privacybrowser/SettingsFragment.java @@ -20,6 +20,7 @@ package com.stoutner.privacybrowser; import android.annotation.SuppressLint; +import android.app.Activity; import android.content.SharedPreferences; import android.os.Build; import android.os.Bundle; @@ -91,12 +92,12 @@ public class SettingsFragment extends PreferenceFragment { javaScriptDisabledSearchCustomURLPreference.setEnabled(javaScriptDisabledSearchString.equals("Custom URL")); - // Set the JavaScript-enabed searchURL as the summary text for the JavaScript-enabled search preference when the preference screen is loaded. + // Set the JavaScript-enabled searchURL as the summary text for the JavaScript-enabled search preference when the preference screen is loaded. // The default is "https://duckduckgo.com/?q=". final Preference javaScriptEnabledSearchPreference = findPreference("javascript_enabled_search"); String javaScriptEnabledSearchString = savedPreferences.getString("javascript_enabled_search", "https://duckduckgo.com/?q="); if (javaScriptEnabledSearchString.equals("Custom URL")) { - // If set to "Custom URL", use R.string.custom_url, which will be tgranslated, instead of the array value, which will not. + // If set to "Custom URL", use R.string.custom_url, which will be translated, instead of the array value, which will not. javaScriptEnabledSearchPreference.setSummary(R.string.custom_url); } else { // Set the array value as the summary text. @@ -128,83 +129,81 @@ public class SettingsFragment extends PreferenceFragment { switch (key) { case "javascript_enabled": - // Set javaScriptEnabled to the new state. The default is false. + // Set `javaScriptEnabled` to the new state. The default is `false`. MainWebViewActivity.javaScriptEnabled = sharedPreferences.getBoolean("javascript_enabled", false); - // Toggle the state of the "dom_storage_enabled" preference. The default is false. + // Toggle the state of the `dom_storage_enabled` preference. The default is `false`. final Preference domStorageEnabled = findPreference("dom_storage_enabled"); domStorageEnabled.setEnabled(sharedPreferences.getBoolean("javascript_enabled", false)); - // Update mainWebView and reload the website. + // Update `mainWebView`. MainWebViewActivity.mainWebView.getSettings().setJavaScriptEnabled(MainWebViewActivity.javaScriptEnabled); - MainWebViewActivity.mainWebView.reload(); - // Update the privacy icon. - updatePrivacyIcon(); + // Update the privacy icons. + MainWebViewActivity.updatePrivacyIcons(MainWebViewActivity.privacyBrowserActivity); break; case "first_party_cookies_enabled": - // Set firstPartyCookiesEnabled to the new state. The default is false. + // Set `firstPartyCookiesEnabled` to the new state. The default is `false`. MainWebViewActivity.firstPartyCookiesEnabled = sharedPreferences.getBoolean("first_party_cookies_enabled", false); - // Toggle the state of the "third_party_cookies_enabled" preference. The default is false. + // Toggle the state of the `third_party_cookies_enabled` preference. The default is `false`. final Preference thirdPartyCookiesEnabled = findPreference("third_party_cookies_enabled"); thirdPartyCookiesEnabled.setEnabled(sharedPreferences.getBoolean("first_party_cookies_enabled", false)); - // Update mainWebView and reload the website. + // Update `mainWebView`. MainWebViewActivity.cookieManager.setAcceptCookie(MainWebViewActivity.firstPartyCookiesEnabled); - MainWebViewActivity.mainWebView.reload(); // Update the checkbox in the options menu. MenuItem firstPartyCookiesMenuItem = MainWebViewActivity.mainMenu.findItem(R.id.toggleFirstPartyCookies); firstPartyCookiesMenuItem.setChecked(MainWebViewActivity.firstPartyCookiesEnabled); - // Update the privacy icon. - updatePrivacyIcon(); + // Update the privacy icons. + MainWebViewActivity.updatePrivacyIcons(MainWebViewActivity.privacyBrowserActivity); break; case "third_party_cookies_enabled": - // Set thirdPartyCookiesEnabled to the new state. The default is false. + // Set `thirdPartyCookiesEnabled` to the new state. The default is `false`. MainWebViewActivity.thirdPartyCookiesEnabled = sharedPreferences.getBoolean("third_party_cookies_enabled", false); // Update the checkbox in the options menu. MenuItem thirdPartyCookiesMenuItem = MainWebViewActivity.mainMenu.findItem(R.id.toggleThirdPartyCookies); thirdPartyCookiesMenuItem.setChecked(MainWebViewActivity.thirdPartyCookiesEnabled); - // Update mainWebView and reload the website if API >= 21. + // Update `mainWebView` if API >= 21. if (Build.VERSION.SDK_INT >= 21) { MainWebViewActivity.cookieManager.setAcceptThirdPartyCookies(MainWebViewActivity.mainWebView, MainWebViewActivity.thirdPartyCookiesEnabled); - MainWebViewActivity.mainWebView.reload(); } break; case "dom_storage_enabled": - // Set domStorageEnabled to the new state. The default is false. + // Set `domStorageEnabled` to the new state. The default is `false`. MainWebViewActivity.domStorageEnabled = sharedPreferences.getBoolean("dom_storage_enabled", false); // Update the checkbox in the options menu. MenuItem domStorageMenuItem = MainWebViewActivity.mainMenu.findItem(R.id.toggleDomStorage); domStorageMenuItem.setChecked(MainWebViewActivity.domStorageEnabled); - // Update mainWebView and reload the website. + // Update `mainWebView`. MainWebViewActivity.mainWebView.getSettings().setDomStorageEnabled(MainWebViewActivity.domStorageEnabled); - MainWebViewActivity.mainWebView.reload(); - // Update the privacy icon. - updatePrivacyIcon(); + // Update the privacy icons. + MainWebViewActivity.updatePrivacyIcons(MainWebViewActivity.privacyBrowserActivity); break; case "save_form_data_enabled": - // Set saveFormDataEnabled to the new state. The default is false. + // Set `saveFormDataEnabled` to the new state. The default is `false`. MainWebViewActivity.saveFormDataEnabled = sharedPreferences.getBoolean("save_form_data_enabled", false); // Update the checkbox in the options menu. MenuItem saveFormDataMenuItem = MainWebViewActivity.mainMenu.findItem(R.id.toggleSaveFormData); saveFormDataMenuItem.setChecked(MainWebViewActivity.saveFormDataEnabled); - // Update mainWebView and reload the website. + // Update `mainWebView`. MainWebViewActivity.mainWebView.getSettings().setSaveFormData(MainWebViewActivity.saveFormDataEnabled); - MainWebViewActivity.mainWebView.reload(); + + // Update the privacy icons. + MainWebViewActivity.updatePrivacyIcons(MainWebViewActivity.privacyBrowserActivity); break; case "user_agent": @@ -212,7 +211,7 @@ public class SettingsFragment extends PreferenceFragment { switch (userAgentString) { case "Default user agent": - // Set the default user agent on mainWebView, display the user agent as the summary text for userAgentPreference, and disable customUserAgent. + // Set the default user agent on `mainWebView`, display the user agent as the summary text for `userAgentPreference`, and disable `customUserAgent`. // Once API >= 17 we can use getDefaultUserAgent(). For now, setUserAgentString("") sets the WebView's default user agent. MainWebViewActivity.mainWebView.getSettings().setUserAgentString(""); userAgentPreference.setSummary(MainWebViewActivity.mainWebView.getSettings().getUserAgentString()); @@ -243,6 +242,17 @@ public class SettingsFragment extends PreferenceFragment { MainWebViewActivity.mainWebView.getSettings().setUserAgentString(sharedPreferences.getString("custom_user_agent", "PrivacyBrowser/1.0")); break; + case "proxy_through_orbot": + // Get a handle for `settingsActivity`. + Activity settingsActivity = getActivity(); + + // Update the proxy. The default is `false` + if (sharedPreferences.getBoolean("proxy_through_orbot", false)) { // Orbot proxies on localhost port 8118. + OrbotProxyHelper.setProxy(MainWebViewActivity.privacyBrowserContext, settingsActivity, "localhost", "8118"); + } else { // Disable the proxy by setting the host to `null` and the port to `0`. + OrbotProxyHelper.setProxy(MainWebViewActivity.privacyBrowserContext, settingsActivity, "", "0"); + } + case "javascript_disabled_search": String newJavaScriptDisabledSearchString = sharedPreferences.getString("javascript_disabled_search", "https://duckduckgo.com/html/?q="); if (newJavaScriptDisabledSearchString.equals("Custom URL")) { @@ -292,18 +302,26 @@ public class SettingsFragment extends PreferenceFragment { break; case "javascript_enabled_search_custom_url": - // Set the new custom search URL as the summary text for "javascript_enabled_search_custom_url". The default is "". + // Set the new custom search URL as the summary text for `javascript_enabled_search_custom_url`. The default is ``. javaScriptEnabledSearchCustomURLPreference.setSummary(sharedPreferences.getString("javascript_enabled_search_custom_url", "")); - // Update javaScriptEnabledSearchCustomURL. The default is "". + // Update javaScriptEnabledSearchCustomURL. The default is ``. MainWebViewActivity.javaScriptEnabledSearchURL = sharedPreferences.getString("javascript_enabled_search_custom_url", ""); break; + case "do_not_track": + // Update `customHeaders`. The default is `true`. + if (sharedPreferences.getBoolean("do_not_track", true)) { + MainWebViewActivity.customHeaders.put("DNT", "1"); + } else { // Remove the Do Not Track header. + MainWebViewActivity.customHeaders.remove("DNT"); + } + case "homepage": - // Set the new homepage URL as the summary text for the Homepage preference. The default is "https://www.duckduckgo.com". + // Set the new homepage URL as the summary text for the Homepage preference. The default is `https://www.duckduckgo.com`. homepagePreference.setSummary(sharedPreferences.getString("homepage", "https://www.duckduckgo.com")); - // Update the homepage variable. The default is "https://www.duckduckgo.com". + // Update the homepage variable. The default is `https://www.duckduckgo.com`. MainWebViewActivity.homepage = sharedPreferences.getString("homepage", "https://www.duckduckgo.com"); break; @@ -349,19 +367,4 @@ public class SettingsFragment extends PreferenceFragment { super.onResume(); savedPreferences.registerOnSharedPreferenceChangeListener(preferencesListener); } - - private void updatePrivacyIcon() { - // Define a reference to the toggleJavaScript icon. - MenuItem toggleJavaScript = MainWebViewActivity.mainMenu.findItem(R.id.toggleJavaScript); - - if (MainWebViewActivity.javaScriptEnabled) { - toggleJavaScript.setIcon(R.drawable.javascript_enabled); - } else { - if (MainWebViewActivity.firstPartyCookiesEnabled) { - toggleJavaScript.setIcon(R.drawable.warning); - } else { - toggleJavaScript.setIcon(R.drawable.privacy_mode); - } - } - } }