X-Git-Url: https://gitweb.stoutner.com/?a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fres%2Flayout%2Fabout_tab_version.xml;h=0fd5201355cba484e49305dfd086dff8456a3680;hb=0cb3e2266b503767b74535e794c674ea97773154;hp=7aa3b794cdc2a5705746270e636d72424fbbdada;hpb=44014ce1673cb4cbfcdaeceac59c067a5074b35c;p=PrivacyBrowserAndroid.git

diff --git a/app/src/main/res/layout/about_tab_version.xml b/app/src/main/res/layout/about_tab_version.xml
index 7aa3b794..0fd52013 100644
--- a/app/src/main/res/layout/about_tab_version.xml
+++ b/app/src/main/res/layout/about_tab_version.xml
@@ -18,29 +18,26 @@
   You should have received a copy of the GNU General Public License
   along with Privacy Browser.  If not, see <http://www.gnu.org/licenses/>. -->
 
-<!-- The ScrollView allows the LinearLayout to scroll if it exceeds the height of the page. -->
+<!-- The `ScrollView` allows the `LinearLayout` to scroll if it exceeds the height of the page. -->
 <ScrollView
-    android:id="@+id/about_version_scrollview"
     xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     android:layout_height="wrap_content"
     android:layout_width="match_parent" >
 
     <LinearLayout
-        android:id="@+id/about_version_linearlayout"
         android:layout_height="wrap_content"
         android:layout_width="match_parent"
         android:orientation="vertical"
-        android:padding="16dp">
+        android:padding="16dp" >
 
-        <!-- The RelativeLayout contains the header. -->
+        <!-- The `RelativeLayout` contains the header. -->
         <RelativeLayout
-            android:id="@+id/about_version_relativelayout"
             android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            xmlns:tools="http://schemas.android.com/tools">
+            android:layout_height="wrap_content" >
 
-            <!--tools:ignore="ContentDescription" suppresses the lint warning about supplying a content description for the ImageView,
-              which isn't needed in this case because the ImageView is only decorative. -->
+            <!--`tools:ignore="ContentDescription"` suppresses the lint warning about supplying a content description for the `ImageView`,
+              which isn't needed in this case because the `ImageView` is only decorative. -->
             <ImageView
                 android:id="@+id/about_version_icon"
                 android:layout_width="wrap_content"
@@ -49,7 +46,6 @@
                 android:paddingTop="10dp"
                 tools:ignore="ContentDescription" />
 
-            <!-- We need to include android:layout_toRightOf until API>=17. -->
             <TextView
                 android:id="@+id/about_version_privacy_browser_textview"
                 android:layout_width="wrap_content"
@@ -58,36 +54,29 @@
                 android:textStyle="bold"
                 android:textSize="22sp"
                 android:textColor="@color/black"
-                android:layout_toEndOf="@id/about_version_icon"
-                android:layout_toRightOf="@id/about_version_icon" />
+                android:layout_toEndOf="@id/about_version_icon" />
 
-            <!-- We need to include android:layout_toRightOf until API>=17. -->
             <TextView
-                android:id="@+id/about_version_number_text"
+                android:id="@+id/about_version_number"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:textColor="@color/blue"
                 android:layout_below="@id/about_version_privacy_browser_textview"
-                android:layout_toEndOf="@id/about_version_icon"
-                android:layout_toRightOf="@id/about_version_icon" />
+                android:layout_toEndOf="@id/about_version_icon" />
         </RelativeLayout>
 
-        <!-- The purpose of this LinearLayout is to provide padding on the start of the TextViews to make them line up with about_version_icon.
-          We have to use android:paddingLeft in addition to android:paddingStart until API>=17.
-          Although we don't need them, we have to include android:paddingEnd and android:paddingRight to make lint happy. -->
+        <!-- The purpose of this `LinearLayout` is to provide padding on the start of the `TextViews` to make them line up with `about_version_icon`.
+          Although we don't need it, we have to include `android:paddingEnd` to make lint happy. -->
         <LinearLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:orientation="vertical"
             android:paddingTop="16dp"
             android:paddingStart="4dp"
-            android:paddingEnd="0dp"
-            android:paddingLeft="4dp"
-            android:paddingRight="4dp">
+            android:paddingEnd="0dp" >
 
             <!-- Hardware. -->
             <TextView
-                android:id="@+id/about_version_hardware"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:text="@string/hardware"
@@ -95,123 +84,38 @@
                 android:textSize="18sp"
                 android:textColor="@color/dark_blue" />
 
-            <!-- Brand. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_brand"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
+                android:layout_height="wrap_content" />
 
-                <TextView
-                    android:id="@+id/about_version_brand_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/brand" />
-
-                <TextView
-                    android:id="@+id/about_version_brand_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
-
-            <!-- Manufacturer. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_manufacturer"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_manufacturer_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/manufacturer" />
-
-                <TextView
-                    android:id="@+id/about_version_manufacturer_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
+                android:layout_height="wrap_content" />
 
-            <!-- Model. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_model"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_model_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/model" />
+                android:layout_height="wrap_content" />
 
-                <TextView
-                    android:id="@+id/about_version_model_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
-
-            <!-- Device. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_device"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
+                android:layout_height="wrap_content"/>
 
-                <TextView
-                    android:id="@+id/about_version_device_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/device" />
-
-                <TextView
-                    android:id="@+id/about_version_device_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
-
-            <!-- Bootloader. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_bootloader"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_bootloader_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/bootloader" />
-
-                <TextView
-                    android:id="@+id/about_version_bootloader_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
+                android:layout_height="wrap_content" />
 
-            <!-- Radio. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_radio"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_radio_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/radio" />
-
-                <TextView
-                    android:id="@+id/about_version_radio_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
+                android:layout_height="wrap_content"/>
 
             <!-- Software. -->
             <TextView
-                android:id="@+id/about_version_software"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
                 android:text="@string/software"
@@ -220,100 +124,30 @@
                 android:textColor="@color/dark_blue"
                 android:paddingTop="12dp" />
 
-            <!-- Android. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_android"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_android_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/android" />
-
-                <TextView
-                    android:id="@+id/about_version_android_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
+                android:layout_height="wrap_content"/>
 
-            <!-- Build. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_build"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_build_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/build" />
+                android:layout_height="wrap_content"/>
 
-                <TextView
-                    android:id="@+id/about_version_build_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
-
-            <!-- Security Patch. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_securitypatch"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_securitypatch_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/security_patch" />
-
-                <TextView
-                    android:id="@+id/about_version_securitypatch_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-                </LinearLayout>
+                android:layout_height="wrap_content" />
 
-            <!-- WebKit. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_webkit"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_webkit_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/webkit" />
+                android:layout_height="wrap_content"/>
 
-                <TextView
-                    android:id="@+id/about_version_webkit_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
-
-            <!-- Chrome. -->
-            <LinearLayout
+            <TextView
+                android:id="@+id/about_version_chrome"
                 android:layout_width="wrap_content"
-                android:layout_height="wrap_content"
-                android:orientation="horizontal" >
-
-                <TextView
-                    android:id="@+id/about_version_chrome_title"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/chrome" />
-
-                <TextView
-                    android:id="@+id/about_version_chrome_text"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:textColor="@color/blue" />
-            </LinearLayout>
+                android:layout_height="wrap_content" />
         </LinearLayout>
     </LinearLayout>
 </ScrollView>
\ No newline at end of file