X-Git-Url: https://gitweb.stoutner.com/?a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fres%2Flayout%2Fabout_tab_version.xml;h=75bcb3e842d0fd126b87c3236061a502224098db;hb=d277b46fdd35b734dcace8c20ee9db431d2aa1da;hp=444187eedf4cd6936572519dd4f417119862fabb;hpb=49e94a767e452d451a722bbb068e46458e404ed9;p=PrivacyBrowserAndroid.git

diff --git a/app/src/main/res/layout/about_tab_version.xml b/app/src/main/res/layout/about_tab_version.xml
index 444187ee..75bcb3e8 100644
--- a/app/src/main/res/layout/about_tab_version.xml
+++ b/app/src/main/res/layout/about_tab_version.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <!--
-  Copyright © 2016-2018 Soren Stoutner <soren@stoutner.com>.
+  Copyright © 2016-2018,2020 Soren Stoutner <soren@stoutner.com>.
 
   This file is part of Privacy Browser <https://www.stoutner.com/privacy-browser>.
 
@@ -18,13 +18,12 @@
   You should have received a copy of the GNU General Public License
   along with Privacy Browser.  If not, see <http://www.gnu.org/licenses/>. -->
 
-<!-- The `ScrollView` allows the `LinearLayout` to scroll if it exceeds the height of the page. -->
+<!-- The scroll view allows the linear layout to scroll if it exceeds the height of the page. -->
 <ScrollView
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_height="wrap_content"
-    android:layout_width="match_parent"
-    android:background="?attr/aboutBackground" >
+    android:layout_width="match_parent" >
 
     <LinearLayout
         android:layout_height="wrap_content"
@@ -37,36 +36,40 @@
             android:layout_width="match_parent"
             android:layout_height="wrap_content" >
 
-            <!-- `tools:ignore="ContentDescription"` suppresses the lint warning about supplying a content description for the `ImageView`,
-                 which isn't needed in this case because the `ImageView` is only decorative. -->
+            <!--`tools:ignore="RtlSymmetry"` suppressed the lint warning about adding `android:paddingStart`, which wouldn't work with this layout.
+                `tools:ignore="ContentDescription"` suppresses the lint warning about supplying a content description for the image view,
+                which isn't needed in this case because the image view is only decorative. -->
             <ImageView
-                android:id="@+id/about_version_icon"
+                android:id="@+id/icon"
                 android:layout_height="wrap_content"
                 android:layout_width="wrap_content"
                 android:src="@mipmap/privacy_browser"
                 android:paddingTop="10dp"
-                tools:ignore="ContentDescription" />
+                android:paddingEnd="5dp"
+                tools:ignore="RtlSymmetry,ContentDescription" />
 
             <TextView
-                android:id="@+id/about_version_privacy_browser_textview"
+                android:id="@+id/privacy_browser_textview"
                 android:layout_height="wrap_content"
                 android:layout_width="wrap_content"
                 android:text="@string/privacy_browser"
                 android:textStyle="bold"
                 android:textSize="22sp"
-                android:textColor="?attr/aboutTitle"
-                android:layout_toEndOf="@id/about_version_icon" />
+                android:textColor="?attr/blueTitleTextColor"
+                android:paddingTop="12dp"
+                android:layout_toEndOf="@id/icon" />
 
             <TextView
-                android:id="@+id/about_version_number"
+                android:id="@+id/version"
                 android:layout_height="wrap_content"
                 android:layout_width="wrap_content"
-                android:textColor="?attr/aboutText"
-                android:layout_below="@id/about_version_privacy_browser_textview"
-                android:layout_toEndOf="@id/about_version_icon" />
+                android:textColor="?attr/blueTextColor"
+                android:textIsSelectable="true"
+                android:layout_below="@id/privacy_browser_textview"
+                android:layout_toEndOf="@id/icon" />
         </RelativeLayout>
 
-        <!-- The purpose of this `LinearLayout` is to provide padding on the start of the `TextViews` to make them line up with `about_version_icon`.
+        <!-- The purpose of this linear layout is to provide padding on the start of the text views to make them line up with `about_version_icon`.
              Although we don't need it, we have to include `android:paddingEnd` to make lint happy. -->
         <LinearLayout
             android:layout_height="wrap_content"
@@ -83,37 +86,43 @@
                 android:text="@string/hardware"
                 android:textStyle="bold"
                 android:textSize="18sp"
-                android:textColor="?attr/aboutTitle" />
+                android:textColor="?attr/blueTitleTextColor" />
 
             <TextView
-                android:id="@+id/about_version_brand"
+                android:id="@+id/brand"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_manufacturer"
+                android:id="@+id/manufacturer"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_model"
+                android:id="@+id/model"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_device"
+                android:id="@+id/device"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_bootloader"
+                android:id="@+id/bootloader"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_radio"
+                android:id="@+id/radio"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <!-- Software. -->
             <TextView
@@ -122,68 +131,102 @@
                 android:text="@string/software"
                 android:textStyle="bold"
                 android:textSize="18sp"
-                android:textColor="?attr/aboutTitle"
+                android:textColor="?attr/blueTitleTextColor"
                 android:paddingTop="12dp" />
 
             <TextView
-                android:id="@+id/about_version_android"
+                android:id="@+id/android"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
+
+            <TextView
+                android:id="@+id/security_patch"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
+
+            <TextView
+                android:id="@+id/build"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_securitypatch"
+                android:id="@+id/webview_provider"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_build"
+                android:id="@+id/webview_version"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_webkit"
+                android:id="@+id/orbot"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_chrome"
+                android:id="@+id/i2p"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_orbot"
+                android:id="@+id/open_keychain"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <!-- Block Lists. -->
             <TextView
                 android:layout_height="wrap_content"
                 android:layout_width="wrap_content"
-                android:text="@string/block_lists"
+                android:text="@string/blocklists"
                 android:textStyle="bold"
                 android:textSize="18sp"
-                android:textColor="?attr/aboutTitle"
+                android:textColor="?attr/blueTitleTextColor"
                 android:paddingTop="12dp" />
 
             <TextView
-                android:id="@+id/about_version_easylist"
+                android:id="@+id/easylist"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
+
+            <TextView
+                android:id="@+id/easyprivacy"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_easyprivacy"
+                android:id="@+id/fanboy_annoyance"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_fanboy-annoyance"
+                android:id="@+id/fanboy_social"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_fanboy-social"
+                android:id="@+id/ultralist"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
+
+            <TextView
+                android:id="@+id/ultraprivacy"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <!-- Package Signature. -->
             <TextView
@@ -192,43 +235,50 @@
                 android:text="@string/package_signature"
                 android:textStyle="bold"
                 android:textSize="18sp"
-                android:textColor="?attr/aboutTitle"
+                android:textColor="?attr/blueTitleTextColor"
                 android:paddingTop="12dp" />
 
             <TextView
-                android:id="@+id/about_version_certificate_issuer_dn"
+                android:id="@+id/certificate_issuer_dn"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_certificate_subject_dn"
+                android:id="@+id/certificate_subject_dn"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_certificate_start_date"
+                android:id="@+id/certificate_start_date"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_certificate_end_date"
+                android:id="@+id/certificate_end_date"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_certificate_version"
+                android:id="@+id/certificate_version"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_certificate_serial_number"
+                android:id="@+id/certificate_serial_number"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
 
             <TextView
-                android:id="@+id/about_version_certificate_signature_algorithm"
+                android:id="@+id/certificate_signature_algorithm"
                 android:layout_height="wrap_content"
-                android:layout_width="wrap_content" />
+                android:layout_width="wrap_content"
+                android:textIsSelectable="true" />
         </LinearLayout>
     </LinearLayout>
 </ScrollView>
\ No newline at end of file