From 6ab00381e1005dbfd4e05302afa54614f96cbea1 Mon Sep 17 00:00:00 2001 From: Soren Stoutner Date: Sat, 30 Dec 2023 11:44:55 -0700 Subject: [PATCH] Change the default for scrolling the app bar to false. https://redmine.stoutner.com/issues/1130 --- .../stoutner/privacybrowser/activities/MainWebViewActivity.kt | 2 +- .../com/stoutner/privacybrowser/fragments/SettingsFragment.kt | 4 ++-- app/src/main/res/xml/preferences.xml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/stoutner/privacybrowser/activities/MainWebViewActivity.kt b/app/src/main/java/com/stoutner/privacybrowser/activities/MainWebViewActivity.kt index f43e66d1..85b3ae76 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/activities/MainWebViewActivity.kt +++ b/app/src/main/java/com/stoutner/privacybrowser/activities/MainWebViewActivity.kt @@ -3104,7 +3104,7 @@ class MainWebViewActivity : AppCompatActivity(), CreateBookmarkDialog.CreateBook fullScreenBrowsingModeEnabled = sharedPreferences.getBoolean(getString(R.string.full_screen_browsing_mode_key), false) hideAppBar = sharedPreferences.getBoolean(getString(R.string.hide_app_bar_key), true) downloadWithExternalApp = sharedPreferences.getBoolean(getString(R.string.download_with_external_app_key), false) - scrollAppBar = sharedPreferences.getBoolean(getString(R.string.scroll_app_bar_key), true) + scrollAppBar = sharedPreferences.getBoolean(getString(R.string.scroll_app_bar_key), false) // Apply the saved proxy mode if the app has been restarted. if (savedProxyMode != null) { diff --git a/app/src/main/java/com/stoutner/privacybrowser/fragments/SettingsFragment.kt b/app/src/main/java/com/stoutner/privacybrowser/fragments/SettingsFragment.kt index eb74fce3..45496278 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/fragments/SettingsFragment.kt +++ b/app/src/main/java/com/stoutner/privacybrowser/fragments/SettingsFragment.kt @@ -522,7 +522,7 @@ class SettingsFragment : PreferenceFragmentCompat() { downloadWithExternalAppPreference.setIcon(R.drawable.download_with_external_app_disabled) // Set the scroll app bar icon. - if (sharedPreferences.getBoolean(getString(R.string.scroll_app_bar_key), true)) + if (sharedPreferences.getBoolean(getString(R.string.scroll_app_bar_key), false)) scrollAppBarPreference.setIcon(R.drawable.app_bar_enabled) else scrollAppBarPreference.setIcon(R.drawable.app_bar_disabled) @@ -1078,7 +1078,7 @@ class SettingsFragment : PreferenceFragmentCompat() { getString(R.string.scroll_app_bar_key) -> { // Update the icon. - if (sharedPreferences.getBoolean(getString(R.string.scroll_app_bar_key), true)) + if (sharedPreferences.getBoolean(getString(R.string.scroll_app_bar_key), false)) scrollAppBarPreference.setIcon(R.drawable.app_bar_enabled) else scrollAppBarPreference.setIcon(R.drawable.app_bar_disabled) diff --git a/app/src/main/res/xml/preferences.xml b/app/src/main/res/xml/preferences.xml index ac2b6a4c..345ad307 100644 --- a/app/src/main/res/xml/preferences.xml +++ b/app/src/main/res/xml/preferences.xml @@ -286,7 +286,7 @@ app:key="@string/scroll_app_bar_key" app:title="@string/scroll_app_bar" app:summary="@string/scroll_app_bar_summary" - app:defaultValue="true" /> + app:defaultValue="false" />