Implement saving a webpage as an image. https://redmine.stoutner.com/issues/187

[PrivacyBrowserAndroid.git] / app / src / main / java / com / stoutner / privacybrowser / activities / LogcatActivity.java

diff --git a/app/src/main/java/com/stoutner/privacybrowser/activities/LogcatActivity.java b/app/src/main/java/com/stoutner/privacybrowser/activities/LogcatActivity.java
index eb0ba2dc16294295649d4b110a82965cbf6c7ebb..f270cd24db670e42caa0b6ec3eb136ff50bdb111 100644 (file)
--- a/app/src/main/java/com/stoutner/privacybrowser/activities/LogcatActivity.java
+++ b/app/src/main/java/com/stoutner/privacybrowser/activities/LogcatActivity.java
@@ -28,10 +28,8 @@ import android.content.Intent;
 import android.content.SharedPreferences;
 import android.content.pm.PackageManager;
 import android.media.MediaScannerConnection;
-import android.net.Uri;
 import android.os.AsyncTask;
 import android.os.Bundle;
-import android.os.Environment;
 import android.preference.PreferenceManager;
 import android.view.Menu;
 import android.view.MenuItem;
@@ -49,9 +47,11 @@ import androidx.fragment.app.DialogFragment;
 import androidx.swiperefreshlayout.widget.SwipeRefreshLayout;
 
 import com.google.android.material.snackbar.Snackbar;
+
 import com.stoutner.privacybrowser.R;
 import com.stoutner.privacybrowser.dialogs.StoragePermissionDialog;
 import com.stoutner.privacybrowser.dialogs.SaveLogcatDialog;
+import com.stoutner.privacybrowser.helpers.FileNameHelper;
 
 import java.io.BufferedReader;
 import java.io.BufferedWriter;
@@ -166,7 +166,7 @@ public class LogcatActivity extends AppCompatActivity implements SaveLogcatDialo
                 return true;
 
             case R.id.save:
-                // Get a handle for the save alert dialog.
+                // Instantiate the save alert dialog.
                 DialogFragment saveDialogFragment = new SaveLogcatDialog();
 
                 // Show the save alert dialog.
@@ -233,7 +233,7 @@ public class LogcatActivity extends AppCompatActivity implements SaveLogcatDialo
                     // Show the storage permission alert dialog.  The permission will be requested when the dialog is closed.
                     storagePermissionDialogFragment.show(getSupportFragmentManager(), getString(R.string.storage_permission));
                 } else {  // Show the permission request directly.
-                    // Request the storage permission.  The logcat will be saved when it finishes.
+                    // Request the write external storage permission.  The logcat will be saved when it finishes.
                     ActivityCompat.requestPermissions(this, new String[] {Manifest.permission.WRITE_EXTERNAL_STORAGE}, 0);
 
                 }
@@ -317,65 +317,22 @@ public class LogcatActivity extends AppCompatActivity implements SaveLogcatDialo
             // Get a handle for the save dialog fragment.
             DialogFragment saveDialogFragment = (DialogFragment) getSupportFragmentManager().findFragmentByTag(getString(R.string.save_logcat));
 
-            // Remove the incorrect lint error that the save dialog fragment might be null.
-            assert saveDialogFragment != null;
-
-            // Get a handle for the save dialog.
-            Dialog saveDialog = saveDialogFragment.getDialog();
-
-            // Get a handle for the file name edit text.
-            EditText fileNameEditText = saveDialog.findViewById(R.id.file_name_edittext);
-
-            // Get the file name URI.
-            Uri fileNameUri = data.getData();
-
-            // Remove the incorrect lint warning that the file name URI might be null.
-            assert fileNameUri != null;
-
-            // Get the raw file name path.
-            String rawFileNamePath = fileNameUri.getPath();
-
-            // Remove the incorrect lint warning that the file name path might be null.
-            assert rawFileNamePath != null;
+            // Only update the file name if the dialog still exists.
+            if (saveDialogFragment != null) {
+                // Get a handle for the save dialog.
+                Dialog saveDialog = saveDialogFragment.getDialog();
 
-            // Check to see if the file name Path includes a valid storage location.
-            if (rawFileNamePath.contains(":")) {  // The path is valid.
-                // Split the path into the initial content uri and the final path information.
-                String fileNameContentPath = rawFileNamePath.substring(0, rawFileNamePath.indexOf(":"));
-                String fileNameFinalPath = rawFileNamePath.substring(rawFileNamePath.indexOf(":") + 1);
+                // Get a handle for the file name edit text.
+                EditText fileNameEditText = saveDialog.findViewById(R.id.file_name_edittext);
 
-                // Create the file name path string.
-                String fileNamePath;
+                // Instantiate the file name helper.
+                FileNameHelper fileNameHelper = new FileNameHelper();
 
-                // Construct the file name path.
-                switch (fileNameContentPath) {
-                    // The documents home has a special content path.
-                    case "/document/home":
-                        fileNamePath = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOCUMENTS) + "/" + fileNameFinalPath;
-                        break;
-
-                    // Everything else for the primary user should be in `/document/primary`.
-                    case "/document/primary":
-                        fileNamePath = Environment.getExternalStorageDirectory() + "/" + fileNameFinalPath;
-                        break;
-
-                    // Just in case, catch everything else and place it in the external storage directory.
-                    default:
-                        fileNamePath = Environment.getExternalStorageDirectory() + "/" + fileNameFinalPath;
-                        break;
-                }
+                // Convert the file name URI to a file name path.
+                String fileNamePath = fileNameHelper.convertUriToFileNamePath(data.getData());
 
                 // Set the file name path as the text of the file name edit text.
                 fileNameEditText.setText(fileNamePath);
-            } else {  // The path is invalid.
-                // Close the alert dialog.
-                saveDialog.dismiss();
-
-                // Get a handle for the logcat text view.
-                TextView logcatTextView = findViewById(R.id.logcat_textview);
-
-                // Display a snackbar with the error message.
-                Snackbar.make(logcatTextView, rawFileNamePath + " " + getString(R.string.invalid_location), Snackbar.LENGTH_INDEFINITE).show();
             }
         }
     }