First wrong button text in View Headers in night theme. https://redmine.stoutner...

[PrivacyBrowserAndroid.git] / app / src / main / java / com / stoutner / privacybrowser / dialogs / CreateHomeScreenShortcutDialog.kt

diff --git a/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateHomeScreenShortcutDialog.kt b/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateHomeScreenShortcutDialog.kt
index 784d0f1237f131fba020942384693b5e27093d0b..841456e3e591d3ddb88411eef9e58b9f2951d7f1 100644 (file)
--- a/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateHomeScreenShortcutDialog.kt
+++ b/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateHomeScreenShortcutDialog.kt
@@ -1,5 +1,5 @@
 /*
- * Copyright © 2015-2022 Soren Stoutner <soren@stoutner.com>.
+ * Copyright © 2015-2024 Soren Stoutner <soren@stoutner.com>.
  *
  * This file is part of Privacy Browser Android <https://www.stoutner.com/privacy-browser-android>.
  *
@@ -49,20 +49,13 @@ import com.stoutner.privacybrowser.R
 
 import java.io.ByteArrayOutputStream
 
-// Define the class constants.
-private const val SHORTCUT_NAME = "shortcut_name"
-private const val URL_STRING = "url_string"
-private const val FAVORITE_ICON_BYTE_ARRAY = "favorite_icon_byte_array"
+// Define the private class constants.
+private const val SHORTCUT_NAME = "A"
+private const val URL_STRING = "B"
+private const val FAVORITE_ICON_BYTE_ARRAY = "C"
 
 class CreateHomeScreenShortcutDialog : DialogFragment() {
-    // Declare the class views.
-    private lateinit var shortcutNameEditText: EditText
-    private lateinit var urlEditText: EditText
-    private lateinit var openWithPrivacyBrowserRadioButton: RadioButton
-
     companion object {
-        // `@JvmStatic` will no longer be required once all the code has transitioned to Kotlin.
-        @JvmStatic
         fun createDialog(shortcutName: String, urlString: String, favoriteIconBitmap: Bitmap): CreateHomeScreenShortcutDialog {
             // Create a favorite icon byte array output stream.
             val favoriteIconByteArrayOutputStream = ByteArrayOutputStream()
@@ -92,6 +85,11 @@ class CreateHomeScreenShortcutDialog : DialogFragment() {
         }
     }
 
+    // Declare the class variables.
+    private lateinit var shortcutNameEditText: EditText
+    private lateinit var urlEditText: EditText
+    private lateinit var openWithPrivacyBrowserRadioButton: RadioButton
+
     override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
         // Get the arguments.
         val arguments = requireArguments()
@@ -132,7 +130,7 @@ class CreateHomeScreenShortcutDialog : DialogFragment() {
         val alertDialog = dialogBuilder.create()
 
         // Get a handle for the shared preferences.
-        val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(context)
+        val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(requireContext())
 
         // Get the screenshot preference.
         val allowScreenshots = sharedPreferences.getBoolean(getString(R.string.allow_screenshots_key), false)
@@ -241,7 +239,7 @@ class CreateHomeScreenShortcutDialog : DialogFragment() {
         val shortcutName = shortcutNameEditText.text.toString()
         val urlString = urlEditText.text.toString()
 
-        // Convert the favorite icon bitmap to an icon.  `IconCompat` must be used until the minimum API >= 26.
+        // Convert the favorite icon bitmap to an icon.
         val favoriteIcon = IconCompat.createWithBitmap(favoriteIconBitmap)
 
         // Create a shortcut intent.
@@ -264,7 +262,7 @@ class CreateHomeScreenShortcutDialog : DialogFragment() {
         shortcutInfoBuilder.setIntent(shortcutIntent)
         shortcutInfoBuilder.setShortLabel(shortcutName)
 
-        // Add the shortcut to the home screen.  `ShortcutManagerCompat` can be switched to `ShortcutManager` once the minimum API >= 26.
+        // Add the shortcut to the home screen.
         ShortcutManagerCompat.requestPinShortcut(requireContext(), shortcutInfoBuilder.build(), null)
     }
 }
\ No newline at end of file