Fix the bookmarks dialogs to align the icons and the radio buttons. https://redmine...

[PrivacyBrowserAndroid.git] / app / src / main / res / layout / edit_bookmark_dialog.xml

diff --git a/app/src/main/res/layout/edit_bookmark_dialog.xml b/app/src/main/res/layout/edit_bookmark_dialog.xml
index 43a427d1d6d8eecf1ee2d02cbd5a8d2c859444dc..8ce9763b971f5487a44c3010201bbeaec16f794e 100644 (file)
--- a/app/src/main/res/layout/edit_bookmark_dialog.xml
+++ b/app/src/main/res/layout/edit_bookmark_dialog.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="utf-8"?>
 
 <!--
-  Copyright © 2016-2017,2019-2020 Soren Stoutner <soren@stoutner.com>.
+  Copyright © 2016-2017,2019-2021 Soren Stoutner <soren@stoutner.com>.
 
   This file is part of Privacy Browser <https://www.stoutner.com/privacy-browser>.
 
@@ -29,66 +29,72 @@
         android:layout_width="match_parent"
         android:orientation="vertical" >
 
-        <!-- The icon selection rows. -->
+        <!-- Current icon. -->
         <LinearLayout
+            android:id="@+id/current_icon_linearlayout"
             android:layout_height="wrap_content"
             android:layout_width="match_parent"
-            android:orientation="horizontal" >
+            android:orientation="horizontal"
+            android:layout_marginTop="12dp"
+            android:layout_marginBottom="6dp" >
 
-            <!-- The column displaying the icons. -->
-            <LinearLayout
+            <RadioButton
+                android:id="@+id/current_icon_radiobutton"
                 android:layout_height="wrap_content"
                 android:layout_width="wrap_content"
-                android:orientation="vertical"
-                android:layout_marginStart="7dp" >
-
-                <ImageView
-                    android:id="@+id/edit_bookmark_current_icon"
-                    android:layout_width="30dp"
-                    android:layout_height="30dp"
-                    android:layout_marginTop="12dp"
-                    android:layout_marginBottom="6dp"
-                    android:layout_gravity="center_vertical"
-                    tools:ignore="ContentDescription" />
-
-                <ImageView
-                    android:id="@+id/edit_bookmark_webpage_favorite_icon"
-                    android:layout_width="30dp"
-                    android:layout_height="30dp"
-                    android:layout_marginTop="6dp"
-                    android:layout_marginBottom="6dp"
-                    tools:ignore="ContentDescription" />
-            </LinearLayout>
-
-            <!-- The column with the `RadioGroup`. -->
-            <RadioGroup
-                android:id="@+id/edit_bookmark_icon_radiogroup"
+                android:layout_gravity="center_vertical"
+                android:checked="true" />
+
+            <ImageView
+                android:id="@+id/current_icon_imageview"
+                android:layout_width="30dp"
+                android:layout_height="30dp"
+                android:layout_gravity="center_vertical"
+                tools:ignore="ContentDescription" />
+
+            <TextView
                 android:layout_height="wrap_content"
-                android:layout_width="match_parent"
-                android:checkedButton="@+id/edit_bookmark_current_icon_radiobutton" >
-
-                <RadioButton
-                    android:id="@id/edit_bookmark_current_icon_radiobutton"
-                    android:layout_height="wrap_content"
-                    android:layout_width="wrap_content"
-                    android:layout_marginTop="12dp"
-                    android:layout_marginBottom="4dp"
-                    android:text="@string/current_bookmark_icon"
-                    android:textSize="18sp"
-                    android:textColor="?android:textColorPrimary" />
-
-                <RadioButton
-                    android:id="@+id/edit_bookmark_webpage_favorite_icon_radiobutton"
-                    android:layout_height="wrap_content"
-                    android:layout_width="wrap_content"
-                    android:layout_marginTop="5dp"
-                    android:text="@string/web_page_favorite_icon"
-                    android:textSize="18sp"
-                    android:textColor="?android:textColorPrimary" />
-            </RadioGroup>
+                android:layout_width="wrap_content"
+                android:layout_marginStart="7dp"
+                android:layout_gravity="center_vertical"
+                android:text="@string/current_bookmark_icon"
+                android:textSize="18sp"
+                android:textColor="?android:textColorPrimary" />
+        </LinearLayout>
+
+        <!-- Webpage favorite icon. -->
+        <LinearLayout
+            android:id="@+id/webpage_favorite_icon_linearlayout"
+            android:layout_height="wrap_content"
+            android:layout_width="match_parent"
+            android:orientation="horizontal"
+            android:layout_marginTop="6dp"
+            android:layout_marginBottom="6dp" >
+
+            <RadioButton
+                android:id="@+id/webpage_favorite_icon_radiobutton"
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:layout_gravity="center_vertical" />
+
+            <ImageView
+                android:id="@+id/webpage_favorite_icon_imageview"
+                android:layout_height="30dp"
+                android:layout_width="30dp"
+                android:layout_gravity="center_vertical"
+                tools:ignore="ContentDescription" />
+
+            <TextView
+                android:layout_height="wrap_content"
+                android:layout_width="wrap_content"
+                android:layout_marginStart="7dp"
+                android:layout_gravity="center_vertical"
+                android:text="@string/webpage_favorite_icon"
+                android:textSize="18sp"
+                android:textColor="?android:textColorPrimary" />
         </LinearLayout>
 
-        <!-- The `TextInputLayout` makes the `android:hint` float above the edit text. -->
+        <!-- The text input layout makes the `android:hint` float above the edit text. -->
         <com.google.android.material.textfield.TextInputLayout
             android:layout_height="wrap_content"
             android:layout_width="match_parent"
@@ -97,9 +103,9 @@
             android:layout_marginStart="4dp"
             android:layout_marginEnd="4dp" >
 
-            <!-- `android:imeOptions="actionGo"` sets the keyboard to have a `go` key instead of a `new line` key.  `android:inputType="textUri"` disables spell check in the edit text. -->
+            <!-- `android:imeOptions="actionGo"` sets the keyboard to have a "go" key instead of a "new line" key.  `android:inputType="textUri"` disables spell check in the edit text. -->
             <com.google.android.material.textfield.TextInputEditText
-                android:id="@+id/edit_bookmark_name_edittext"
+                android:id="@+id/bookmark_name_edittext"
                 android:layout_height="wrap_content"
                 android:layout_width="match_parent"
                 android:hint="@string/bookmark_name"
@@ -108,7 +114,7 @@
                 android:selectAllOnFocus="true" />
         </com.google.android.material.textfield.TextInputLayout>
 
-        <!-- The `TextInputLayout` makes the `android:hint` float above the edit text. -->
+        <!-- The text input layout makes the `android:hint` float above the edit text. -->
         <com.google.android.material.textfield.TextInputLayout
             android:layout_height="wrap_content"
             android:layout_width="match_parent"
@@ -117,9 +123,9 @@
             android:layout_marginStart="4dp"
             android:layout_marginEnd="4dp" >
 
-            <!-- `android:imeOptions="actionGo"` sets the keyboard to have a `go` key instead of a `new line` key.  `android:inputType="textUri"` disables spell check in the edit text. -->
+            <!-- `android:imeOptions="actionGo"` sets the keyboard to have a "go" key instead of a "new line" key.  `android:inputType="textUri"` disables spell check in the edit text. -->
             <com.google.android.material.textfield.TextInputEditText
-                android:id="@+id/edit_bookmark_url_edittext"
+                android:id="@+id/bookmark_url_edittext"
                 android:layout_height="wrap_content"
                 android:layout_width="match_parent"
                 android:hint="@string/bookmark_url"