Refactor the options menu variables. https://redmine.stoutner.com/issues/650

[PrivacyBrowserAndroid.git] / app / src / main / res / menu / webview_options_menu.xml

diff --git a/app/src/main/res/menu/webview_options_menu.xml b/app/src/main/res/menu/webview_options_menu.xml
index d298b13411ba03e13ea2b7efe115da0cfe45a263..4b6b610cd545d536654d25192cbdd11183150a79 100644 (file)
--- a/app/src/main/res/menu/webview_options_menu.xml
+++ b/app/src/main/res/menu/webview_options_menu.xml
@@ -25,7 +25,7 @@
     tools:context=".activities.MainWebViewActivity" >
 
     <item
-        android:id="@+id/toggle_javascript"
+        android:id="@+id/javascript"
         android:title="@string/javascript"
         android:orderInCategory="100"
         android:icon="@drawable/privacy_mode"
@@ -37,14 +37,16 @@
         android:orderInCategory="200"
         app:showAsAction="never" />
 
+    <!-- `android:iconTint` can be used once the minimum API >= 26 instead of including a separate drawable for each theme. -->
     <item
         android:id="@+id/bookmarks"
         android:title="@string/bookmarks"
         android:orderInCategory="300"
+        android:icon="?attr/bookmarksAppBarIcon"
         app:showAsAction="never" />
 
     <item
-        android:id="@+id/toggle_first_party_cookies"
+        android:id="@+id/first_party_cookies"
         android:title="@string/first_party_cookies"
         android:orderInCategory="400"
         android:checkable="true"
@@ -52,22 +54,21 @@
         app:showAsAction="never" />
 
     <item
-        android:id="@+id/toggle_third_party_cookies"
+        android:id="@+id/third_party_cookies"
         android:title="@string/third_party_cookies"
         android:orderInCategory="500"
         android:checkable="true"
         app:showAsAction="never" />
 
     <item
-        android:id="@+id/toggle_dom_storage"
+        android:id="@+id/dom_storage"
         android:title="@string/dom_storage"
         android:orderInCategory="600"
         android:checkable="true"
-        android:icon="@drawable/dom_storage_disabled_day"
         app:showAsAction="never" />
 
     <item
-        android:id="@+id/toggle_save_form_data"
+        android:id="@+id/save_form_data"
         android:title="@string/form_data"
         android:orderInCategory="700"
         android:checkable="true"
@@ -311,8 +312,8 @@
                 app:showAsAction="never" />
 
             <item
-                android:id="@+id/night_mode"
-                android:title="@string/options_night_mode"
+                android:id="@+id/dark_webview"
+                android:title="@string/dark_webview"
                 android:orderInCategory="1160"
                 android:checkable="true"
                 app:showAsAction="never" />
@@ -348,14 +349,14 @@
                         android:orderInCategory="1201"
                         app:showAsAction="never" />
                     <item
-                        android:id="@+id/save_as_archive"
-                        android:title="@string/save_as_archive"
+                        android:id="@+id/save_archive"
+                        android:title="@string/save_archive"
                         android:orderInCategory="1202"
                         app:showAsAction="never" />
 
                     <item
-                        android:id="@+id/save_as_image"
-                        android:title="@string/save_as_image"
+                        android:id="@+id/save_image"
+                        android:title="@string/save_image"
                         android:orderInCategory="1203"
                         app:showAsAction="never" />
                 </menu>