X-Git-Url: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fjava%2Fcom%2Fstoutner%2Fprivacybrowser%2Fadapters%2FWebViewPagerAdapter.java;h=8c15bc51753ced8a94ee2ec4c1a8a8ff2483bccc;hp=d7ea9cf072984bc83b71e041d63d3f762b5ea98c;hb=ab11ca2de00c56982e46627c8e7fc670462b0b3c;hpb=9d5e4c56326502b6b74e8f3e463275f5c1e176cc diff --git a/app/src/main/java/com/stoutner/privacybrowser/adapters/WebViewPagerAdapter.java b/app/src/main/java/com/stoutner/privacybrowser/adapters/WebViewPagerAdapter.java index d7ea9cf0..8c15bc51 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/adapters/WebViewPagerAdapter.java +++ b/app/src/main/java/com/stoutner/privacybrowser/adapters/WebViewPagerAdapter.java @@ -1,5 +1,5 @@ /* - * Copyright © 2019 Soren Stoutner . + * Copyright © 2019-2021 Soren Stoutner . * * This file is part of Privacy Browser . * @@ -19,23 +19,29 @@ package com.stoutner.privacybrowser.adapters; -import com.stoutner.privacybrowser.fragments.WebViewTabFragment; - -import java.util.LinkedList; +import android.os.Bundle; +import android.widget.FrameLayout; import androidx.annotation.NonNull; import androidx.fragment.app.Fragment; import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentPagerAdapter; +import androidx.viewpager.widget.ViewPager; + +import com.stoutner.privacybrowser.R; +import com.stoutner.privacybrowser.fragments.WebViewTabFragment; +import com.stoutner.privacybrowser.views.NestedScrollWebView; + +import java.util.LinkedList; public class WebViewPagerAdapter extends FragmentPagerAdapter { // The WebView fragments list contains all the WebViews. - private LinkedList webViewFragmentsList = new LinkedList<>(); + private final LinkedList webViewFragmentsList = new LinkedList<>(); // Define the constructor. - public WebViewPagerAdapter(FragmentManager fragmentManager){ + public WebViewPagerAdapter(FragmentManager fragmentManager) { // Run the default commands. - super(fragmentManager); + super(fragmentManager, BEHAVIOR_RESUME_ONLY_CURRENT_FRAGMENT); } @Override @@ -58,6 +64,7 @@ public class WebViewPagerAdapter extends FragmentPagerAdapter { } @Override + @NonNull public Fragment getItem(int pageNumber) { // Get the fragment for a particular page. Page numbers are 0 indexed. return webViewFragmentsList.get(pageNumber); @@ -88,27 +95,73 @@ public class WebViewPagerAdapter extends FragmentPagerAdapter { i++; } + // Set the position to be the last tab if it is not found. + // Sometimes there is a race condition in populating the webView fragments list when resuming Privacy Browser and displaying an SSL certificate error while loading a new intent. + // In that case, the last tab should be the one it is looking for. + if (position == -1) { + position = webViewFragmentsList.size() - 1; + } + // Return the position. return position; } - public void addPage(int pageNumber) { + public void addPage(int pageNumber, ViewPager webViewPager, String url, boolean moveToNewPage) { // Add a new page. - webViewFragmentsList.add(WebViewTabFragment.createPage(pageNumber)); + webViewFragmentsList.add(WebViewTabFragment.createPage(pageNumber, url)); + + // Update the view pager. + notifyDataSetChanged(); + + // Move to the new page if indicated. + if (moveToNewPage) { + webViewPager.setCurrentItem(pageNumber); + } + } + + public void restorePage(Bundle savedState, Bundle savedNestedScrollWebViewState) { + // Restore the page. + webViewFragmentsList.add(WebViewTabFragment.restorePage(savedState, savedNestedScrollWebViewState)); // Update the view pager. notifyDataSetChanged(); } - public void deletePage(int pageNumber) { + public boolean deletePage(int pageNumber, ViewPager webViewPager) { + // Get the WebView tab fragment. + WebViewTabFragment webViewTabFragment = webViewFragmentsList.get(pageNumber); + + // Get the WebView frame layout. + FrameLayout webViewFrameLayout = (FrameLayout) webViewTabFragment.getView(); + + // Remove the warning below that the WebView frame layout might be null. + assert webViewFrameLayout != null; + + // Get a handle for the nested scroll WebView. + NestedScrollWebView nestedScrollWebView = webViewFrameLayout.findViewById(R.id.nestedscroll_webview); + + // Pause the current WebView. + nestedScrollWebView.onPause(); + + // Remove all the views from the frame layout. + webViewFrameLayout.removeAllViews(); + + // Destroy the current WebView. + nestedScrollWebView.destroy(); + // Delete the page. webViewFragmentsList.remove(pageNumber); // Update the view pager. notifyDataSetChanged(); + + // Return true if the selected page number did not change after the delete (because the newly selected tab has has same number as the previously deleted tab). + // This will cause the calling method to reset the current WebView to the new contents of this page number. + return (webViewPager.getCurrentItem() == pageNumber); } public WebViewTabFragment getPageFragment(int pageNumber) { + // Return the page fragment. return webViewFragmentsList.get(pageNumber); } } \ No newline at end of file