X-Git-Url: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fjava%2Fcom%2Fstoutner%2Fprivacybrowser%2Fasynctasks%2FSaveUrl.java;h=ad200216751887d0004e67dcab866f6505804918;hp=6b383f4e40de02e435a289cbfcda5fb52973d9fc;hb=1003c7842a01f338c8aaf9d4f07216111f294202;hpb=4196bafc4069857b554ac95addcae92fcabae901 diff --git a/app/src/main/java/com/stoutner/privacybrowser/asynctasks/SaveUrl.java b/app/src/main/java/com/stoutner/privacybrowser/asynctasks/SaveUrl.java index 6b383f4e..ad200216 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/asynctasks/SaveUrl.java +++ b/app/src/main/java/com/stoutner/privacybrowser/asynctasks/SaveUrl.java @@ -20,7 +20,6 @@ package com.stoutner.privacybrowser.asynctasks; import android.app.Activity; -import android.content.ActivityNotFoundException; import android.content.ContentResolver; import android.content.Context; import android.content.Intent; @@ -50,7 +49,7 @@ import java.net.URL; import java.text.NumberFormat; public class SaveUrl extends AsyncTask { - // Define a weak references for the calling context and activity. + // Define a weak references. private WeakReference contextWeakReference; private WeakReference activityWeakReference; @@ -248,7 +247,7 @@ public class SaveUrl extends AsyncTask { // Check to see if a download percentage has been calculated. if (downloadPercentage[0] < 0) { // There is no download percentage. The negative number represents the raw downloaded kilobytes. // Calculate the number of bytes downloaded. When the `downloadPercentage` is negative, it is actually the raw number of kilobytes downloaded. - long numberOfBytesDownloaded = 0 - downloadPercentage[0]; + long numberOfBytesDownloaded = - downloadPercentage[0]; // Format the number of bytes downloaded. String formattedNumberOfBytesDownloaded = NumberFormat.getInstance().format(numberOfBytesDownloaded); @@ -286,11 +285,11 @@ public class SaveUrl extends AsyncTask { // Add an open action if the file is not an APK on API >= 26 (that scenario requires the REQUEST_INSTALL_PACKAGES permission). if (!(Build.VERSION.SDK_INT >= 26 && filePathString.endsWith(".apk"))) { - fileSavedSnackbar.setAction(R.string.open, (View v) -> { + fileSavedSnackbar.setAction(R.string.open, (View view) -> { // Get a file for the file path string. File file = new File(filePathString); - // Define a file URI variable + // Declare a file URI variable. Uri fileUri; // Get the URI for the file according to the Android version. @@ -316,14 +315,8 @@ public class SaveUrl extends AsyncTask { // Allow the app to read the file URI. openIntent.setFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION); - // Try the intent. - try { - // Show the chooser. - activity.startActivity(openIntent); - } catch (ActivityNotFoundException exception) { // There are no apps available to open the URL. - // Show a snackbar with the error. - Snackbar.make(noSwipeViewPager, activity.getString(R.string.error) + " " + exception, Snackbar.LENGTH_INDEFINITE).show(); - } + // Show the chooser. + activity.startActivity(Intent.createChooser(openIntent, context.getString(R.string.open))); }); }