X-Git-Url: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fjava%2Fcom%2Fstoutner%2Fprivacybrowser%2Fdialogs%2FCreateBookmarkDialog.kt;h=5bfd99c392211fd3286d0870581a030f56c97f3e;hp=a10e574a5a003ff012849fb6a1ce5e77373e0929;hb=aba828cabddd0a277271c90816b50292bb64baf1;hpb=74655c0cd0ba72c80ac6c48df55bc3d2f5280ad2 diff --git a/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateBookmarkDialog.kt b/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateBookmarkDialog.kt index a10e574a..5bfd99c3 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateBookmarkDialog.kt +++ b/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateBookmarkDialog.kt @@ -1,25 +1,24 @@ /* - * Copyright © 2016-2020 Soren Stoutner . + * Copyright © 2016-2022 Soren Stoutner . * - * This file is part of Privacy Browser . + * This file is part of Privacy Browser Android . * - * Privacy Browser is free software: you can redistribute it and/or modify + * Privacy Browser Android is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * - * Privacy Browser is distributed in the hope that it will be useful, + * Privacy Browser Android is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with Privacy Browser. If not, see . + * along with Privacy Browser Android. If not, see . */ package com.stoutner.privacybrowser.dialogs -import android.annotation.SuppressLint import android.app.Dialog import android.content.Context import android.content.DialogInterface @@ -41,15 +40,20 @@ import com.stoutner.privacybrowser.R import java.io.ByteArrayOutputStream -class CreateBookmarkDialog: DialogFragment() { +// Define the class constants. +private const val URL_STRING = "url_string" +private const val TITLE = "title" +private const val FAVORITE_ICON_BYTE_ARRAY = "favorite_icon_byte_array" + +class CreateBookmarkDialog : DialogFragment() { + // Declare the class variables + private lateinit var createBookmarkListener: CreateBookmarkListener + // The public interface is used to send information back to the parent activity. interface CreateBookmarkListener { fun onCreateBookmark(dialogFragment: DialogFragment, favoriteIconBitmap: Bitmap) } - // The create bookmark listener is initialized in `onAttach()` and used in `onCreateDialog()`. - private lateinit var createBookmarkListener: CreateBookmarkListener - override fun onAttach(context: Context) { // Run the default commands. super.onAttach(context) @@ -59,9 +63,9 @@ class CreateBookmarkDialog: DialogFragment() { } companion object { - // `@JvmStatic` will no longer be required once all the code has transitioned to Kotlin. Also, the function can then be moved out of a companion object and just become a package-level function. + // `@JvmStatic` will no longer be required once all the code has transitioned to Kotlin. @JvmStatic - fun createBookmark(urlString: String, titleString: String, favoriteIconBitmap: Bitmap): CreateBookmarkDialog { + fun createBookmark(urlString: String, title: String, favoriteIconBitmap: Bitmap): CreateBookmarkDialog { // Create a favorite icon byte array output stream. val favoriteIconByteArrayOutputStream = ByteArrayOutputStream() @@ -75,9 +79,9 @@ class CreateBookmarkDialog: DialogFragment() { val argumentsBundle = Bundle() // Store the variables in the bundle. - argumentsBundle.putString("url_string", urlString) - argumentsBundle.putString("title_string", titleString) - argumentsBundle.putByteArray("favorite_icon_byte_array", favoriteIconByteArray) + argumentsBundle.putString(URL_STRING, urlString) + argumentsBundle.putString(TITLE, title) + argumentsBundle.putByteArray(FAVORITE_ICON_BYTE_ARRAY, favoriteIconByteArray) // Create a new instance of the dialog. val createBookmarkDialog = CreateBookmarkDialog() @@ -90,16 +94,14 @@ class CreateBookmarkDialog: DialogFragment() { } } - // `@SuppressLing("InflateParams")` removes the warning about using `null` as the parent view group when inflating the alert dialog. - @SuppressLint("InflateParams") override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { // Get the arguments. val arguments = requireArguments() // Get the contents of the arguments. - val urlString = arguments.getString("url_string") - val titleString = arguments.getString("title_string") - val favoriteIconByteArray = arguments.getByteArray("favorite_icon_byte_array")!! + val urlString = arguments.getString(URL_STRING) + val title = arguments.getString(TITLE) + val favoriteIconByteArray = arguments.getByteArray(FAVORITE_ICON_BYTE_ARRAY)!! // Convert the favorite icon byte array to a bitmap. val favoriteIconBitmap = BitmapFactory.decodeByteArray(favoriteIconByteArray, 0, favoriteIconByteArray.size) @@ -116,8 +118,8 @@ class CreateBookmarkDialog: DialogFragment() { // Set the icon. dialogBuilder.setIcon(favoriteIconDrawable) - // Set the view. The parent view is `null` because it will be assigned by the alert dialog. - dialogBuilder.setView(requireActivity().layoutInflater.inflate(R.layout.create_bookmark_dialog, null)) + // Set the view. + dialogBuilder.setView(R.layout.create_bookmark_dialog) // Set a listener on the cancel button. Using `null` as the listener closes the dialog without doing anything else. dialogBuilder.setNegativeButton(R.string.cancel, null) @@ -133,10 +135,10 @@ class CreateBookmarkDialog: DialogFragment() { // Get a handle for the shared preferences. - val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(context) + val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(requireContext()) // Get the screenshot preference. - val allowScreenshots = sharedPreferences.getBoolean("allow_screenshots", false) + val allowScreenshots = sharedPreferences.getBoolean(getString(R.string.allow_screenshots_key), false) // Disable screenshots if not allowed. if (!allowScreenshots) { @@ -151,7 +153,7 @@ class CreateBookmarkDialog: DialogFragment() { val createBookmarkUrlEditText = alertDialog.findViewById(R.id.create_bookmark_url_edittext)!! // Set the initial texts for the edit texts. - createBookmarkNameEditText.setText(titleString) + createBookmarkNameEditText.setText(title) createBookmarkUrlEditText.setText(urlString) // Allow the enter key on the keyboard to create the bookmark from the create bookmark name edit text.