X-Git-Url: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fjava%2Fcom%2Fstoutner%2Fprivacybrowser%2Fdialogs%2FCreateHomeScreenShortcutDialog.kt;h=887ce94213ef38473dbe1a5ac66727122e3ef536;hp=69be19d27344fe231a9c3944e75c7423b6ce353c;hb=aba828cabddd0a277271c90816b50292bb64baf1;hpb=74655c0cd0ba72c80ac6c48df55bc3d2f5280ad2 diff --git a/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateHomeScreenShortcutDialog.kt b/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateHomeScreenShortcutDialog.kt index 69be19d2..887ce942 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateHomeScreenShortcutDialog.kt +++ b/app/src/main/java/com/stoutner/privacybrowser/dialogs/CreateHomeScreenShortcutDialog.kt @@ -1,25 +1,24 @@ /* - * Copyright © 2015-2020 Soren Stoutner . + * Copyright © 2015-2022 Soren Stoutner . * - * This file is part of Privacy Browser . + * This file is part of Privacy Browser Android . * - * Privacy Browser is free software: you can redistribute it and/or modify + * Privacy Browser Android is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * - * Privacy Browser is distributed in the hope that it will be useful, + * Privacy Browser Android is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with Privacy Browser. If not, see . + * along with Privacy Browser Android. If not, see . */ package com.stoutner.privacybrowser.dialogs -import android.annotation.SuppressLint import android.app.Dialog import android.content.DialogInterface import android.content.Intent @@ -50,14 +49,19 @@ import com.stoutner.privacybrowser.R import java.io.ByteArrayOutputStream -class CreateHomeScreenShortcutDialog: DialogFragment() { - // Define the class variables. +// Define the class constants. +private const val SHORTCUT_NAME = "shortcut_name" +private const val URL_STRING = "url_string" +private const val FAVORITE_ICON_BYTE_ARRAY = "favorite_icon_byte_array" + +class CreateHomeScreenShortcutDialog : DialogFragment() { + // Declare the class views. private lateinit var shortcutNameEditText: EditText private lateinit var urlEditText: EditText private lateinit var openWithPrivacyBrowserRadioButton: RadioButton companion object { - // `@JvmStatic` will no longer be required once all the code has transitioned to Kotlin. Also, the function can then be moved out of a companion object and just become a package-level function. + // `@JvmStatic` will no longer be required once all the code has transitioned to Kotlin. @JvmStatic fun createDialog(shortcutName: String, urlString: String, favoriteIconBitmap: Bitmap): CreateHomeScreenShortcutDialog { // Create a favorite icon byte array output stream. @@ -66,16 +70,16 @@ class CreateHomeScreenShortcutDialog: DialogFragment() { // Convert the favorite icon to a PNG and place it in the byte array output stream. `0` is for lossless compression (the only option for a PNG). favoriteIconBitmap.compress(Bitmap.CompressFormat.PNG, 0, favoriteIconByteArrayOutputStream) - // Convert the byte array output stream to a byte array. + // Convert the favorite icon byte array output stream to a byte array. val favoriteIconByteArray = favoriteIconByteArrayOutputStream.toByteArray() // Create an arguments bundle. val argumentsBundle = Bundle() // Store the variables in the bundle. - argumentsBundle.putString("shortcut_name", shortcutName) - argumentsBundle.putString("url_string", urlString) - argumentsBundle.putByteArray("favorite_icon_byte_array", favoriteIconByteArray) + argumentsBundle.putString(SHORTCUT_NAME, shortcutName) + argumentsBundle.putString(URL_STRING, urlString) + argumentsBundle.putByteArray(FAVORITE_ICON_BYTE_ARRAY, favoriteIconByteArray) // Create a new instance of the dialog. val createHomeScreenShortcutDialog = CreateHomeScreenShortcutDialog() @@ -88,34 +92,32 @@ class CreateHomeScreenShortcutDialog: DialogFragment() { } } - // `@SuppressLing("InflateParams")` removes the warning about using `null` as the parent view group when inflating the `AlertDialog`. - @SuppressLint("InflateParams") override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { // Get the arguments. val arguments = requireArguments() - // Get the strings from the arguments. - val initialShortcutName = arguments.getString("shortcut_name") - val initialUrlString = arguments.getString("url_string") - - // Get the favorite icon byte array. - val favoriteIconByteArray = arguments.getByteArray("favorite_icon_byte_array")!! + // Get the variables from the arguments. + val initialShortcutName = arguments.getString(SHORTCUT_NAME) + val initialUrlString = arguments.getString(URL_STRING) + val favoriteIconByteArray = arguments.getByteArray(FAVORITE_ICON_BYTE_ARRAY)!! // Convert the favorite icon byte array to a bitmap. val favoriteIconBitmap = BitmapFactory.decodeByteArray(favoriteIconByteArray, 0, favoriteIconByteArray.size) - // Use an alert dialog builder to create the dialog. - val dialogBuilder = AlertDialog.Builder(requireContext(), R.style.PrivacyBrowserAlertDialog) - // Create a drawable version of the favorite icon. val favoriteIconDrawable: Drawable = BitmapDrawable(resources, favoriteIconBitmap) - // Set the title and icon. + // Use an alert dialog builder to create the dialog. + val dialogBuilder = AlertDialog.Builder(requireContext(), R.style.PrivacyBrowserAlertDialog) + + // Set the title. dialogBuilder.setTitle(R.string.create_shortcut) + + // Set the icon. dialogBuilder.setIcon(favoriteIconDrawable) - // Set the view. The parent view is null because it will be assigned by the alert dialog. - dialogBuilder.setView(requireActivity().layoutInflater.inflate(R.layout.create_home_screen_shortcut_dialog, null)) + // Set the view. + dialogBuilder.setView(R.layout.create_home_screen_shortcut_dialog) // Set a listener on the close button. Using null closes the dialog without doing anything else. dialogBuilder.setNegativeButton(R.string.cancel, null) @@ -130,10 +132,10 @@ class CreateHomeScreenShortcutDialog: DialogFragment() { val alertDialog = dialogBuilder.create() // Get a handle for the shared preferences. - val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(context) + val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(requireContext()) // Get the screenshot preference. - val allowScreenshots = sharedPreferences.getBoolean("allow_screenshots", false) + val allowScreenshots = sharedPreferences.getBoolean(getString(R.string.allow_screenshots_key), false) // Disable screenshots if not allowed. if (!allowScreenshots) {