X-Git-Url: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fjava%2Fcom%2Fstoutner%2Fprivacybrowser%2Fdialogs%2FEditBookmarkDatabaseViewDialog.kt;h=2e5a04f44f337270e154ff4f242ba7bb40471576;hp=7c2012c6d27dc7471043b0409d6dc66cd2dd6824;hb=HEAD;hpb=bc2e180db377eedadbe1ea455d8fb311ead8f9d6 diff --git a/app/src/main/java/com/stoutner/privacybrowser/dialogs/EditBookmarkDatabaseViewDialog.kt b/app/src/main/java/com/stoutner/privacybrowser/dialogs/EditBookmarkDatabaseViewDialog.kt index 7c2012c6..60f76090 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/dialogs/EditBookmarkDatabaseViewDialog.kt +++ b/app/src/main/java/com/stoutner/privacybrowser/dialogs/EditBookmarkDatabaseViewDialog.kt @@ -1,24 +1,24 @@ /* - * Copyright © 2016-2020 Soren Stoutner . + * Copyright 2016-2024 Soren Stoutner . * - * This file is part of Privacy Browser . + * This file is part of Privacy Browser Android . * - * Privacy Browser is free software: you can redistribute it and/or modify + * Privacy Browser Android is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * - * Privacy Browser is distributed in the hope that it will be useful, + * Privacy Browser Android is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License - * along with Privacy Browser. If not, see . + * along with Privacy Browser Android. If not, see . */ + package com.stoutner.privacybrowser.dialogs -import android.annotation.SuppressLint import android.app.Dialog import android.content.Context import android.content.DialogInterface @@ -27,6 +27,7 @@ import android.database.MatrixCursor import android.database.MergeCursor import android.graphics.Bitmap import android.graphics.BitmapFactory +import android.net.Uri import android.os.Bundle import android.text.Editable import android.text.TextWatcher @@ -38,55 +39,40 @@ import android.widget.AdapterView.OnItemSelectedListener import android.widget.Button import android.widget.EditText import android.widget.ImageView +import android.widget.LinearLayout import android.widget.RadioButton -import android.widget.RadioGroup import android.widget.Spinner import android.widget.TextView +import androidx.activity.result.contract.ActivityResultContracts import androidx.appcompat.app.AlertDialog -import androidx.core.content.ContextCompat +import androidx.appcompat.content.res.AppCompatResources import androidx.cursoradapter.widget.ResourceCursorAdapter import androidx.fragment.app.DialogFragment import androidx.preference.PreferenceManager +import com.google.android.material.snackbar.Snackbar + import com.stoutner.privacybrowser.R -import com.stoutner.privacybrowser.activities.BookmarksDatabaseViewActivity +import com.stoutner.privacybrowser.activities.HOME_FOLDER_DATABASE_ID +import com.stoutner.privacybrowser.activities.HOME_FOLDER_ID +import com.stoutner.privacybrowser.helpers.BOOKMARK_NAME +import com.stoutner.privacybrowser.helpers.BOOKMARK_URL +import com.stoutner.privacybrowser.helpers.DISPLAY_ORDER +import com.stoutner.privacybrowser.helpers.FAVORITE_ICON +import com.stoutner.privacybrowser.helpers.FOLDER_ID +import com.stoutner.privacybrowser.helpers.ID +import com.stoutner.privacybrowser.helpers.PARENT_FOLDER_ID import com.stoutner.privacybrowser.helpers.BookmarksDatabaseHelper import java.io.ByteArrayOutputStream -// Declare the class constants. -private const val DATABASE_ID = "database_id" -private const val FAVORITE_ICON_BYTE_ARRAY = "favorite_icon_byte_array" - -class EditBookmarkDatabaseViewDialog: DialogFragment() { - // The public interface is used to send information back to the parent activity. - interface EditBookmarkDatabaseViewListener { - fun onSaveBookmark(dialogFragment: DialogFragment, selectedBookmarkDatabaseId: Int, favoriteIconBitmap: Bitmap) - } - - // Declare the class variables. - private lateinit var editBookmarkDatabaseViewListener: EditBookmarkDatabaseViewListener - - // Declare the class views. - private lateinit var newIconRadioButton: RadioButton - private lateinit var nameEditText: EditText - private lateinit var urlEditText: EditText - private lateinit var folderSpinner: Spinner - private lateinit var displayOrderEditText: EditText - private lateinit var saveButton: Button - - override fun onAttach(context: Context) { - // Run the default commands. - super.onAttach(context) - - // Get a handle for edit bookmark database view listener from the launching context. - editBookmarkDatabaseViewListener = context as EditBookmarkDatabaseViewListener - } +// Define the class constants. +private const val DATABASE_ID = "A" +private const val FAVORITE_ICON_BYTE_ARRAY = "B" +class EditBookmarkDatabaseViewDialog : DialogFragment() { companion object { - // `@JvmStatic` will no longer be required once all the code has transitioned to Kotlin. Also, the function can then be moved out of a companion object and just become a package-level function. - @JvmStatic fun bookmarkDatabaseId(databaseId: Int, favoriteIconBitmap: Bitmap): EditBookmarkDatabaseViewDialog { // Create a favorite icon byte array output stream. val favoriteIconByteArrayOutputStream = ByteArrayOutputStream() @@ -115,8 +101,66 @@ class EditBookmarkDatabaseViewDialog: DialogFragment() { } } - // `@SuppressLint("InflateParams")` removes the warning about using `null` as the parent view group when inflating the alert dialog. - @SuppressLint("InflateParams") + private val browseActivityResultLauncher = registerForActivityResult(ActivityResultContracts.GetContent()) { imageUri: Uri? -> + // Only do something if the user didn't press back from the file picker. + if (imageUri != null) { + // Get a handle for the content resolver. + val contentResolver = requireContext().contentResolver + + // Get the image MIME type. + val mimeType = contentResolver.getType(imageUri) + + // Decode the image according to the type. + if (mimeType == "image/svg+xml") { // The image is an SVG. + // Display a snackbar. + Snackbar.make(bookmarkNameEditText, getString(R.string.cannot_use_svg), Snackbar.LENGTH_LONG).show() + } else { // The image is not an SVG. + // Get an input stream for the image URI. + val inputStream = contentResolver.openInputStream(imageUri) + + // Get the bitmap from the URI. + // `ImageDecoder.decodeBitmap` can't be used, because when running `Drawable.toBitmap` later the `Software rendering doesn't support hardware bitmaps` error message might be produced. + var imageBitmap = BitmapFactory.decodeStream(inputStream) + + // Scale the image down if it is greater than 128 pixels in either direction. + if ((imageBitmap != null) && ((imageBitmap.height > 128) || (imageBitmap.width > 128))) + imageBitmap = Bitmap.createScaledBitmap(imageBitmap, 128, 128, true) + + // Display the new custom favorite icon. + customIconImageView.setImageBitmap(imageBitmap) + + // Select the custom icon radio button. + customIconLinearLayout.performClick() + } + } + } + + // Declare the class views. + private lateinit var bookmarkNameEditText: EditText + private lateinit var bookmarkUrlEditText: EditText + private lateinit var currentIconRadioButton: RadioButton + private lateinit var customIconImageView: ImageView + private lateinit var customIconLinearLayout: LinearLayout + private lateinit var displayOrderEditText: EditText + private lateinit var folderSpinner: Spinner + private lateinit var saveButton: Button + + // Declare the class variables. + private lateinit var editBookmarkDatabaseViewListener: EditBookmarkDatabaseViewListener + + // The public interface is used to send information back to the parent activity. + interface EditBookmarkDatabaseViewListener { + fun saveBookmark(dialogFragment: DialogFragment, selectedBookmarkDatabaseId: Int) + } + + override fun onAttach(context: Context) { + // Run the default commands. + super.onAttach(context) + + // Get a handle for edit bookmark database view listener from the launching context. + editBookmarkDatabaseViewListener = context as EditBookmarkDatabaseViewListener + } + override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { // Get the arguments. val arguments = requireArguments() @@ -128,8 +172,8 @@ class EditBookmarkDatabaseViewDialog: DialogFragment() { // Convert the favorite icon byte array to a bitmap. val favoriteIconBitmap = BitmapFactory.decodeByteArray(favoriteIconByteArray, 0, favoriteIconByteArray.size) - // Initialize the database helper. The `0` specifies a database version, but that is ignored and set instead using a constant in `BookmarksDatabaseHelper`. - val bookmarksDatabaseHelper = BookmarksDatabaseHelper(context, null, null, 0) + // Initialize the database helper. + val bookmarksDatabaseHelper = BookmarksDatabaseHelper(requireContext()) // Get a cursor with the selected bookmark. val bookmarkCursor = bookmarksDatabaseHelper.getBookmark(bookmarkDatabaseId) @@ -143,8 +187,11 @@ class EditBookmarkDatabaseViewDialog: DialogFragment() { // Set the title. dialogBuilder.setTitle(R.string.edit_bookmark) - // Set the view. The parent view is `null` because it will be assigned by the alert dialog. - dialogBuilder.setView(requireActivity().layoutInflater.inflate(R.layout.edit_bookmark_databaseview_dialog, null)) + // Set the icon. + dialogBuilder.setIcon(R.drawable.bookmark) + + // Set the view. + dialogBuilder.setView(R.layout.edit_bookmark_databaseview_dialog) // Set the cancel button listener. Using `null` as the listener closes the dialog without doing anything else. dialogBuilder.setNegativeButton(R.string.cancel, null) @@ -152,14 +199,14 @@ class EditBookmarkDatabaseViewDialog: DialogFragment() { // Set the save button listener. dialogBuilder.setPositiveButton(R.string.save) { _: DialogInterface, _: Int -> // Return the dialog fragment to the parent activity on save. - editBookmarkDatabaseViewListener.onSaveBookmark(this, bookmarkDatabaseId, favoriteIconBitmap) + editBookmarkDatabaseViewListener.saveBookmark(this, bookmarkDatabaseId) } // Create an alert dialog from the alert dialog builder. val alertDialog = dialogBuilder.create() // Get a handle for the shared preferences. - val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(context) + val sharedPreferences = PreferenceManager.getDefaultSharedPreferences(requireContext()) // Get the screenshot preference. val allowScreenshots = sharedPreferences.getBoolean(getString(R.string.allow_screenshots_key), false) @@ -173,52 +220,53 @@ class EditBookmarkDatabaseViewDialog: DialogFragment() { alertDialog.show() // Get handles for the layout items. - val databaseIdTextView = alertDialog.findViewById(R.id.edit_bookmark_database_id_textview)!! - val iconRadioGroup = alertDialog.findViewById(R.id.edit_bookmark_icon_radiogroup)!! - val currentIconImageView = alertDialog.findViewById(R.id.edit_bookmark_current_icon)!! - val newFavoriteIconImageView = alertDialog.findViewById(R.id.edit_bookmark_webpage_favorite_icon)!! - newIconRadioButton = alertDialog.findViewById(R.id.edit_bookmark_webpage_favorite_icon_radiobutton)!! - nameEditText = alertDialog.findViewById(R.id.edit_bookmark_name_edittext)!! - urlEditText = alertDialog.findViewById(R.id.edit_bookmark_url_edittext)!! - folderSpinner = alertDialog.findViewById(R.id.edit_bookmark_folder_spinner)!! - displayOrderEditText = alertDialog.findViewById(R.id.edit_bookmark_display_order_edittext)!! + val databaseIdTextView = alertDialog.findViewById(R.id.bookmark_database_id_textview)!! + val currentIconLinearLayout = alertDialog.findViewById(R.id.current_icon_linearlayout)!! + currentIconRadioButton = alertDialog.findViewById(R.id.current_icon_radiobutton)!! + val currentIconImageView = alertDialog.findViewById(R.id.current_icon_imageview)!! + val webpageFavoriteIconLinearLayout = alertDialog.findViewById(R.id.webpage_favorite_icon_linearlayout)!! + val webpageFavoriteIconRadioButton = alertDialog.findViewById(R.id.webpage_favorite_icon_radiobutton)!! + val webpageFavoriteIconImageView = alertDialog.findViewById(R.id.webpage_favorite_icon_imageview)!! + customIconLinearLayout = alertDialog.findViewById(R.id.custom_icon_linearlayout)!! + val customIconRadioButton = alertDialog.findViewById(R.id.custom_icon_radiobutton)!! + customIconImageView = alertDialog.findViewById(R.id.custom_icon_imageview)!! + val browseButton = alertDialog.findViewById