X-Git-Url: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=blobdiff_plain;f=app%2Fsrc%2Fmain%2Fjava%2Fcom%2Fstoutner%2Fprivacybrowser%2Ffragments%2FDomainsListFragment.java;h=b28289b0dfcea6bcad8da2640681528b810adabb;hp=3caccf529ca1c0edd842cf76926dd7c6ae3c2be5;hb=ba40295dffd761ccdc95d3b46ca7acbad1f00d5e;hpb=96cf5fae34ebc2ae7ca05322837a859943e19ba0 diff --git a/app/src/main/java/com/stoutner/privacybrowser/fragments/DomainsListFragment.java b/app/src/main/java/com/stoutner/privacybrowser/fragments/DomainsListFragment.java index 3caccf52..b28289b0 100644 --- a/app/src/main/java/com/stoutner/privacybrowser/fragments/DomainsListFragment.java +++ b/app/src/main/java/com/stoutner/privacybrowser/fragments/DomainsListFragment.java @@ -1,5 +1,5 @@ /* - * Copyright © 2017-2018 Soren Stoutner . + * Copyright © 2017-2019 Soren Stoutner . * * This file is part of Privacy Browser . * @@ -20,17 +20,18 @@ package com.stoutner.privacybrowser.fragments; import android.os.Bundle; -import android.support.annotation.NonNull; -import android.support.design.widget.FloatingActionButton; -// `android.support.v4.app.Fragment` must be used until minimum API >= 23. Otherwise `getContext()` cannot be called. -import android.support.v4.app.Fragment; -import android.support.v4.app.FragmentManager; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup; import android.widget.AdapterView; import android.widget.ListView; +import androidx.annotation.NonNull; +import androidx.fragment.app.Fragment; // The AndroidX fragment must be used until minimum API >= 23. Otherwise `getContext()` does not work. +import androidx.fragment.app.FragmentManager; + +import com.google.android.material.floatingactionbutton.FloatingActionButton; + import com.stoutner.privacybrowser.R; import com.stoutner.privacybrowser.activities.DomainsActivity; import com.stoutner.privacybrowser.activities.MainWebViewActivity; @@ -59,8 +60,14 @@ public class DomainsListFragment extends Fragment { // Save the current domain settings if operating in two-paned mode and a domain is currently selected. if (DomainsActivity.twoPanedMode && DomainsActivity.deleteMenuItem.isEnabled()) { + // Get a handle for the domain settings fragment. + Fragment domainSettingsFragment = supportFragmentManager.findFragmentById(R.id.domain_settings_fragment_container); + + // Remove the incorrect lint error below that the domain settings fragment might be null. + assert domainSettingsFragment != null; + // Get a handle for the domain settings fragment view. - View domainSettingsFragmentView = supportFragmentManager.findFragmentById(R.id.domain_settings_fragment_container).getView(); + View domainSettingsFragmentView = domainSettingsFragment.getView(); // Get a handle for the domains activity. DomainsActivity domainsActivity = new DomainsActivity(); @@ -76,7 +83,7 @@ public class DomainsListFragment extends Fragment { Bundle argumentsBundle = new Bundle(); argumentsBundle.putInt(DomainSettingsFragment.DATABASE_ID, DomainsActivity.currentDomainDatabaseId); - // Add `argumentsBundle` to `domainSettingsFragment`. + // Add the arguments bundle to the domain settings fragment. DomainSettingsFragment domainSettingsFragment = new DomainSettingsFragment(); domainSettingsFragment.setArguments(argumentsBundle); @@ -84,7 +91,7 @@ public class DomainsListFragment extends Fragment { if (DomainsActivity.twoPanedMode) { // The device in in two-paned mode. // enable `deleteMenuItem` if the system is not waiting for a `Snackbar` to be dismissed. if (!DomainsActivity.dismissingSnackbar) { - // Enable `deleteMenuItem`. + // Enable the delete menu item. DomainsActivity.deleteMenuItem.setEnabled(true); // Set the delete icon according to the theme. @@ -95,7 +102,7 @@ public class DomainsListFragment extends Fragment { } } - // Display `domainSettingsFragment`. + // Display the domain settings fragment. supportFragmentManager.beginTransaction().replace(R.id.domain_settings_fragment_container, domainSettingsFragment).commit(); } else { // The device in in single-paned mode // Show `deleteMenuItem` if the system is not waiting for a `Snackbar` to be dismissed. @@ -103,11 +110,11 @@ public class DomainsListFragment extends Fragment { DomainsActivity.deleteMenuItem.setVisible(true); } - // Hide `add_domain_fab`. + // Hide the add domain FAB. FloatingActionButton addDomainFAB = getActivity().findViewById(R.id.add_domain_fab); - addDomainFAB.setVisibility(View.GONE); + addDomainFAB.hide(); - // Display `domainSettingsFragment`. + // Display the domain settings fragment. supportFragmentManager.beginTransaction().replace(R.id.domains_listview_fragment_container, domainSettingsFragment).commit(); } });