From: Soren Stoutner <soren@stoutner.com>
Date: Thu, 4 Jul 2019 23:54:12 +0000 (-0700)
Subject: Add a ripple touch animation to the New Tab and Close Tab buttons.  https://redmine... 
X-Git-Tag: v3.2~12
X-Git-Url: https://gitweb.stoutner.com/?p=PrivacyBrowserAndroid.git;a=commitdiff_plain;h=e9c3729dd38f0126892c96e0f47529a492922e69

Add a ripple touch animation to the New Tab and Close Tab buttons.  https://redmine.stoutner.com/issues/437
---

diff --git a/app/build.gradle b/app/build.gradle
index ec728bb4..3b8c832a 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -86,5 +86,5 @@ dependencies {
     implementation 'com.google.android.material:material:1.0.0'
 
     // Only compile Firebase ads for the free flavor.
-    freeImplementation 'com.google.firebase:firebase-ads:17.2.1'
+    freeImplementation 'com.google.firebase:firebase-ads:18.0.0'
 }
\ No newline at end of file
diff --git a/app/src/main/res/layout/main_framelayout.xml b/app/src/main/res/layout/main_framelayout.xml
index a381b996..5e330e24 100644
--- a/app/src/main/res/layout/main_framelayout.xml
+++ b/app/src/main/res/layout/main_framelayout.xml
@@ -141,14 +141,16 @@
                         app:layout_scrollFlags="scroll|enterAlways|snap"
                         android:visibility="gone" >
 
+                        <!-- `android:background="?attr/selectableItemBackground"` adds a ripple animation on touch. -->
                         <ImageView
-                            android:layout_height="wrap_content"
+                            android:layout_height="match_parent"
                             android:layout_width="wrap_content"
                             android:layout_gravity="center_vertical"
                             android:paddingStart="10dp"
                             android:paddingEnd="10dp"
                             android:src="@drawable/close_light"
                             android:tint="?attr/addTabIconTintColor"
+                            android:background="?attr/selectableItemBackground"
                             android:onClick="closeTab"
                             android:contentDescription="@string/close_tab" />
 
@@ -160,14 +162,16 @@
                             app:tabIndicatorGravity="top"
                             app:tabMode="scrollable" />
 
+                        <!-- `android:background="?attr/selectableItemBackground"` adds a ripple animation on touch. -->
                         <ImageView
-                            android:layout_height="wrap_content"
+                            android:layout_height="match_parent"
                             android:layout_width="wrap_content"
                             android:layout_gravity="center_vertical"
                             android:paddingStart="10dp"
                             android:paddingEnd="10dp"
                             android:src="@drawable/add_light"
                             android:tint="?attr/addTabIconTintColor"
+                            android:background="?attr/selectableItemBackground"
                             android:onClick="addTab"
                             android:contentDescription="@string/add_tab" />
                     </LinearLayout>
diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml
index c475ead2..3790cb0c 100644
--- a/app/src/main/res/values-es/strings.xml
+++ b/app/src/main/res/values-es/strings.xml
@@ -203,7 +203,7 @@
 
     <!-- Save Webpage as Image. -->
     <string name="save_image">Guardar imagen</string>
-    <string name="webpage_png">Webpage.png</string>
+    <string name="webpage_png">PaginaWeb.png</string>
     <string name="saving_image">Guardando imagen…</string>
     <string name="image_saved">Imagen guardada.</string>
     <string name="error_saving_image">Error guardando imagen:</string>