From 5f747e35e3555da6a0f89f0444163d578ab1db22 Mon Sep 17 00:00:00 2001 From: Soren Stoutner Date: Thu, 26 Jan 2023 11:58:25 -0700 Subject: [PATCH] Enable the integrated PDF viewer. https://redmine.stoutner.com/issues/835 --- COPYING | 2 +- src/main.cpp | 13 +++++++------ src/widgets/TabWidget.cpp | 10 ++++++++-- src/widgets/TabWidget.h | 2 +- 4 files changed, 17 insertions(+), 10 deletions(-) diff --git a/COPYING b/COPYING index 3b01333..6e02237 100644 --- a/COPYING +++ b/COPYING @@ -1,4 +1,4 @@ -Privacy Browser PC copyright © 2016-2017,2021-2022 Soren Stoutner . +Privacy Browser PC copyright 2016-2017,2021-2023 Soren Stoutner . This file is part of Privacy Browser PC . diff --git a/src/main.cpp b/src/main.cpp index 10ce579..d9accc7 100644 --- a/src/main.cpp +++ b/src/main.cpp @@ -1,5 +1,5 @@ /* - * Copyright © 2022 Soren Stoutner . + * Copyright 2022-2023 Soren Stoutner . * * This file is part of Privacy Browser PC . * @@ -45,26 +45,27 @@ int main(int argc, char *argv[]) KCrash::initialize(); // Instantiate about data, setting the component name, the display name, and the version. - KAboutData aboutData(QStringLiteral("privacybrowser"), i18n("Privacy Browser"), QStringLiteral("0.1")); + KAboutData aboutData(QStringLiteral("privacybrowser"), i18nc("Program Name", "Privacy Browser"), QStringLiteral("0.1")); // Add the author name, job description, email address, and website. - aboutData.addAuthor(i18n("Soren Stoutner"),i18n("Principal developer"), QStringLiteral("soren@stoutner.com"), QStringLiteral("https://www.stoutner.com/")); + aboutData.addAuthor(i18nc("Developer Information", "Soren Stoutner"),i18nc("Developer Information", "Principal developer"), QStringLiteral("soren@stoutner.com"), + QStringLiteral("https://www.stoutner.com/")); // Populate additional about data info. aboutData.setBugAddress("https://redmine.stoutner.com/projects/privacy-browser-pc/issues"); - aboutData.setCopyrightStatement(i18n("Copyright © 2016-2017,2021-2022 Soren Stoutner ")); + aboutData.setCopyrightStatement(i18nc("Copyright", "Copyright 2016-2017,2021-2023 Soren Stoutner ")); aboutData.setDesktopFileName(QStringLiteral("com.stoutner.privacybrowser")); aboutData.setHomepage(QStringLiteral("https://www.stoutner.com/privacy-browser-pc/")); //aboutData.setLicense(KAboutLicense::GPL_V3, KAboutLicense::OrLaterVersions); aboutData.setLicenseTextFile(QStringLiteral(":/licenses/GPLv3+.txt")); aboutData.setOrganizationDomain("stoutner.com"); - aboutData.setShortDescription(i18n("A web browser that respects your privacy.")); + aboutData.setShortDescription(i18nc("Tagline", "A web browser that respects your privacy.")); // Set the application data. KAboutData::setApplicationData(aboutData); // Set the window icon. - application.setWindowIcon(QIcon::fromTheme(QStringLiteral("privacy-browser"), QIcon(":/icons/sc-apps-privacy-browser.svg"))); + application.setWindowIcon(QIcon::fromTheme(QStringLiteral("privacy-browser"), QIcon(QStringLiteral(":/icons/sc-apps-privacy-browser.svg")))); // Create a command line parser. QCommandLineParser commandLineParser; diff --git a/src/widgets/TabWidget.cpp b/src/widgets/TabWidget.cpp index 4edb304..aee71d7 100644 --- a/src/widgets/TabWidget.cpp +++ b/src/widgets/TabWidget.cpp @@ -1,5 +1,5 @@ /* - * Copyright 2022 Soren Stoutner . + * Copyright 2022-2023 Soren Stoutner . * * This file is part of Privacy Browser PC . * @@ -267,7 +267,7 @@ PrivacyWebEngineView* TabWidget::addTab(const bool removeUrlLineEditFocus, const return false; }); - // Disable JavaScript by default (this prevetns JavaScript from being enabled on a new tab before domain settings are loaded). + // Disable JavaScript by default (this prevents JavaScript from being enabled on a new tab before domain settings are loaded). webEngineSettingsPointer->setAttribute(QWebEngineSettings::JavascriptEnabled, false); // Don't allow JavaScript to open windows. @@ -285,6 +285,12 @@ PrivacyWebEngineView* TabWidget::addTab(const bool removeUrlLineEditFocus, const // Limit WebRTC to public IP addresses. webEngineSettingsPointer->setAttribute(QWebEngineSettings::WebRTCPublicInterfacesOnly, true); + // Enable the PDF viewer (it should be enabled by default, but it is nice to be explicit in case the defaults change). + webEngineSettingsPointer->setAttribute(QWebEngineSettings::PdfViewerEnabled, true); + + // Plugins must be enabled for the PDF viewer to work. + webEngineSettingsPointer->setAttribute(QWebEngineSettings::PluginsEnabled, true); + // Update the cookies action. connect(privacyWebEngineViewPointer, &PrivacyWebEngineView::updateCookiesAction, [privacyWebEngineViewPointer, this] (const int numberOfCookies) { diff --git a/src/widgets/TabWidget.h b/src/widgets/TabWidget.h index 6130fc3..4b247f7 100644 --- a/src/widgets/TabWidget.h +++ b/src/widgets/TabWidget.h @@ -1,5 +1,5 @@ /* - * Copyright 2022 Soren Stoutner . + * Copyright 2022-2023 Soren Stoutner . * * This file is part of Privacy Browser PC . * -- 2.43.0