/*
- * Copyright 2016-2023 Soren Stoutner <soren@stoutner.com>.
+ * Copyright 2016-2024 Soren Stoutner <soren@stoutner.com>.
*
* This file is part of Privacy Browser Android <https://www.stoutner.com/privacy-browser-android>.
*
import android.content.DialogInterface
import android.graphics.Bitmap
import android.graphics.BitmapFactory
+import android.net.Uri
import android.os.Bundle
import android.text.Editable
import android.text.TextWatcher
import android.widget.LinearLayout
import android.widget.RadioButton
+import androidx.activity.result.contract.ActivityResultContracts
import androidx.appcompat.app.AlertDialog
+import androidx.appcompat.content.res.AppCompatResources
import androidx.fragment.app.DialogFragment
import androidx.preference.PreferenceManager
+import com.google.android.material.snackbar.Snackbar
+
import com.stoutner.privacybrowser.R
import com.stoutner.privacybrowser.helpers.BOOKMARK_NAME
import com.stoutner.privacybrowser.helpers.BOOKMARK_URL
import java.io.ByteArrayOutputStream
// Define the class constants.
-private const val DATABASE_ID = "database_id"
-private const val FAVORITE_ICON_BYTE_ARRAY = "favorite_icon_byte_array"
+private const val DATABASE_ID = "A"
+private const val FAVORITE_ICON_BYTE_ARRAY = "B"
class EditBookmarkDialog : DialogFragment() {
companion object {
}
}
- // Declare the class variables.
- private lateinit var editBookmarkListener: EditBookmarkListener
+ private val browseActivityResultLauncher = registerForActivityResult(ActivityResultContracts.GetContent()) { imageUri: Uri? ->
+ // Only do something if the user didn't press back from the file picker.
+ if (imageUri != null) {
+ // Get a handle for the content resolver.
+ val contentResolver = requireContext().contentResolver
+
+ // Get the image MIME type.
+ val mimeType = contentResolver.getType(imageUri)
+
+ // Decode the image according to the type.
+ if (mimeType == "image/svg+xml") { // The image is an SVG.
+ // Display a snackbar.
+ Snackbar.make(bookmarkNameEditText, getString(R.string.cannot_use_svg), Snackbar.LENGTH_LONG).show()
+ } else { // The image is not an SVG.
+ // Get an input stream for the image URI.
+ val inputStream = contentResolver.openInputStream(imageUri)
+
+ // Get the bitmap from the URI.
+ // `ImageDecoder.decodeBitmap` can't be used, because when running `Drawable.toBitmap` later the `Software rendering doesn't support hardware bitmaps` error message might be produced.
+ var imageBitmap = BitmapFactory.decodeStream(inputStream)
+
+ // Scale the image down if it is greater than 64 pixels in either direction.
+ if ((imageBitmap != null) && ((imageBitmap.height > 128) || (imageBitmap.width > 128)))
+ imageBitmap = Bitmap.createScaledBitmap(imageBitmap, 128, 128, true)
+
+ // Display the new custom favorite icon.
+ customIconImageView.setImageBitmap(imageBitmap)
+
+ // Select the custom icon radio button.
+ customIconLinearLayout.performClick()
+ }
+ }
+ }
// Declare the class views.
- private lateinit var webpageFavoriteIconRadioButton: RadioButton
- private lateinit var nameEditText: EditText
- private lateinit var urlEditText: EditText
+ private lateinit var currentIconRadioButton: RadioButton
+ private lateinit var customIconLinearLayout: LinearLayout
+ private lateinit var customIconImageView: ImageView
+ private lateinit var bookmarkNameEditText: EditText
+ private lateinit var bookmarkUrlEditText: EditText
private lateinit var saveButton: Button
+ // Declare the class variables.
+ private lateinit var currentName: String
+ private lateinit var currentUrl: String
+ private lateinit var editBookmarkListener: EditBookmarkListener
+
// The public interface is used to send information back to the parent activity.
interface EditBookmarkListener {
- fun onSaveBookmark(dialogFragment: DialogFragment, selectedBookmarkDatabaseId: Int, favoriteIconBitmap: Bitmap)
+ fun saveBookmark(dialogFragment: DialogFragment, selectedBookmarkDatabaseId: Int)
}
override fun onAttach(context: Context) {
// Set the title.
dialogBuilder.setTitle(R.string.edit_bookmark)
+ // Set the icon.
+ dialogBuilder.setIcon(R.drawable.bookmark)
+
// Set the view.
dialogBuilder.setView(R.layout.edit_bookmark_dialog)
// Set the save button listener.
dialogBuilder.setPositiveButton(R.string.save) { _: DialogInterface?, _: Int ->
// Return the dialog fragment to the parent activity.
- editBookmarkListener.onSaveBookmark(this, selectedBookmarkDatabaseId, favoriteIconBitmap)
+ editBookmarkListener.saveBookmark(this, selectedBookmarkDatabaseId)
}
// Create an alert dialog from the builder.
// Get handles for the layout items.
val currentIconLinearLayout = alertDialog.findViewById<LinearLayout>(R.id.current_icon_linearlayout)!!
- val currentIconRadioButton = alertDialog.findViewById<RadioButton>(R.id.current_icon_radiobutton)!!
+ currentIconRadioButton = alertDialog.findViewById(R.id.current_icon_radiobutton)!!
val currentIconImageView = alertDialog.findViewById<ImageView>(R.id.current_icon_imageview)!!
val webpageFavoriteIconLinearLayout = alertDialog.findViewById<LinearLayout>(R.id.webpage_favorite_icon_linearlayout)!!
- webpageFavoriteIconRadioButton = alertDialog.findViewById(R.id.webpage_favorite_icon_radiobutton)!!
+ val webpageFavoriteIconRadioButton = alertDialog.findViewById<RadioButton>(R.id.webpage_favorite_icon_radiobutton)!!
val webpageFavoriteIconImageView = alertDialog.findViewById<ImageView>(R.id.webpage_favorite_icon_imageview)!!
- nameEditText = alertDialog.findViewById(R.id.bookmark_name_edittext)!!
- urlEditText = alertDialog.findViewById(R.id.bookmark_url_edittext)!!
+ customIconLinearLayout = alertDialog.findViewById(R.id.custom_icon_linearlayout)!!
+ val customIconRadioButton = alertDialog.findViewById<RadioButton>(R.id.custom_icon_radiobutton)!!
+ customIconImageView = alertDialog.findViewById(R.id.custom_icon_imageview)!!
+ val browseButton = alertDialog.findViewById<Button>(R.id.browse_button)!!
+ bookmarkNameEditText = alertDialog.findViewById(R.id.bookmark_name_edittext)!!
+ bookmarkUrlEditText = alertDialog.findViewById(R.id.bookmark_url_edittext)!!
saveButton = alertDialog.getButton(AlertDialog.BUTTON_POSITIVE)
// Get the current favorite icon byte array from the cursor.
// Convert the byte array to a bitmap beginning at the first byte and ending at the last.
val currentIconBitmap = BitmapFactory.decodeByteArray(currentIconByteArray, 0, currentIconByteArray.size)
- // Display the current icon bitmap.
- currentIconImageView.setImageBitmap(currentIconBitmap)
+ // Get the current bookmark name and URL.
+ currentName = bookmarkCursor.getString(bookmarkCursor.getColumnIndexOrThrow(BOOKMARK_NAME))
+ currentUrl = bookmarkCursor.getString(bookmarkCursor.getColumnIndexOrThrow(BOOKMARK_URL))
- // Set the webpage favorite icon bitmap.
+ // Populate the views.
+ currentIconImageView.setImageBitmap(currentIconBitmap)
webpageFavoriteIconImageView.setImageBitmap(favoriteIconBitmap)
-
- // Store the current bookmark name and URL.
- val currentName = bookmarkCursor.getString(bookmarkCursor.getColumnIndexOrThrow(BOOKMARK_NAME))
- val currentUrl = bookmarkCursor.getString(bookmarkCursor.getColumnIndexOrThrow(BOOKMARK_URL))
-
- // Populate the edit texts.
- nameEditText.setText(currentName)
- urlEditText.setText(currentUrl)
+ customIconImageView.setImageDrawable(AppCompatResources.getDrawable(requireContext(), R.drawable.world))
+ bookmarkNameEditText.setText(currentName)
+ bookmarkUrlEditText.setText(currentUrl)
// Initially disable the save button.
saveButton.isEnabled = false
// Set the radio button listeners. These perform a click on the linear layout, which contains the necessary logic.
currentIconRadioButton.setOnClickListener { currentIconLinearLayout.performClick() }
webpageFavoriteIconRadioButton.setOnClickListener { webpageFavoriteIconLinearLayout.performClick() }
+ customIconRadioButton.setOnClickListener { customIconLinearLayout.performClick() }
// Set the current icon linear layout click listener.
currentIconLinearLayout.setOnClickListener {
// Check the current icon radio button.
currentIconRadioButton.isChecked = true
- // Uncheck the webpage favorite icon radio button.
+ // Uncheck the other radio buttons.
webpageFavoriteIconRadioButton.isChecked = false
+ customIconRadioButton.isChecked = false
// Update the save button.
- updateSaveButton(currentName, currentUrl)
+ updateSaveButton()
}
// Set the webpage favorite icon linear layout click listener.
// Check the webpage favorite icon radio button.
webpageFavoriteIconRadioButton.isChecked = true
- // Uncheck the current icon radio button.
+ // Uncheck the other radio buttons.
+ currentIconRadioButton.isChecked = false
+ customIconRadioButton.isChecked = false
+
+ // Update the save button.
+ updateSaveButton()
+ }
+
+ // Set the custom icon linear layout click listener.
+ customIconLinearLayout.setOnClickListener {
+ // Check the custom icon radio button.
+ customIconRadioButton.isChecked = true
+
+ // Uncheck the other radio buttons.
currentIconRadioButton.isChecked = false
+ webpageFavoriteIconRadioButton.isChecked = false
// Update the save button.
- updateSaveButton(currentName, currentUrl)
+ updateSaveButton()
+ }
+
+ browseButton.setOnClickListener {
+ // Open the file picker.
+ browseActivityResultLauncher.launch("image/*")
}
// Update the save button if the bookmark name changes.
- nameEditText.addTextChangedListener(object: TextWatcher {
- override fun beforeTextChanged(s: CharSequence, start: Int, count: Int, after: Int) {
+ bookmarkNameEditText.addTextChangedListener(object: TextWatcher {
+ override fun beforeTextChanged(charSequence: CharSequence?, start: Int, count: Int, after: Int) {
// Do nothing.
}
- override fun onTextChanged(s: CharSequence, start: Int, before: Int, count: Int) {
+ override fun onTextChanged(charSequence: CharSequence?, start: Int, before: Int, count: Int) {
// Do nothing.
}
- override fun afterTextChanged(s: Editable) {
+ override fun afterTextChanged(editable: Editable?) {
// Update the save button.
- updateSaveButton(currentName, currentUrl)
+ updateSaveButton()
}
})
// Update the save button if the URL changes.
- urlEditText.addTextChangedListener(object: TextWatcher {
- override fun beforeTextChanged(s: CharSequence, start: Int, count: Int, after: Int) {
+ bookmarkUrlEditText.addTextChangedListener(object: TextWatcher {
+ override fun beforeTextChanged(charSequence: CharSequence?, start: Int, count: Int, after: Int) {
// Do nothing.
}
- override fun onTextChanged(s: CharSequence, start: Int, before: Int, count: Int) {
+ override fun onTextChanged(charSequence: CharSequence?, start: Int, before: Int, count: Int) {
// Do nothing.
}
- override fun afterTextChanged(s: Editable) {
+ override fun afterTextChanged(editable: Editable?) {
// Update the edit button.
- updateSaveButton(currentName, currentUrl)
+ updateSaveButton()
}
})
// Allow the enter key on the keyboard to save the bookmark from the bookmark name edit text.
- nameEditText.setOnKeyListener { _: View?, keyCode: Int, event: KeyEvent ->
+ bookmarkNameEditText.setOnKeyListener { _: View?, keyCode: Int, event: KeyEvent ->
// Check the key code, event, and button status.
if (event.action == KeyEvent.ACTION_DOWN && keyCode == KeyEvent.KEYCODE_ENTER && saveButton.isEnabled) { // The enter key was pressed and the save button is enabled.
// Trigger the listener and return the dialog fragment to the parent activity.
- editBookmarkListener.onSaveBookmark(this, selectedBookmarkDatabaseId, favoriteIconBitmap)
+ editBookmarkListener.saveBookmark(this, selectedBookmarkDatabaseId)
// Manually dismiss the alert dialog.
alertDialog.dismiss()
}
// Allow the enter key on the keyboard to save the bookmark from the URL edit text.
- urlEditText.setOnKeyListener { _: View?, keyCode: Int, event: KeyEvent ->
+ bookmarkUrlEditText.setOnKeyListener { _: View?, keyCode: Int, event: KeyEvent ->
// Check the key code, event, and button status.
if (event.action == KeyEvent.ACTION_DOWN && keyCode == KeyEvent.KEYCODE_ENTER && saveButton.isEnabled) { // The enter key was pressed and the save button is enabled.
// Trigger the listener and return the dialog fragment to the parent activity.
- editBookmarkListener.onSaveBookmark(this, selectedBookmarkDatabaseId, favoriteIconBitmap)
+ editBookmarkListener.saveBookmark(this, selectedBookmarkDatabaseId)
// Manually dismiss the alert dialog.
alertDialog.dismiss()
return alertDialog
}
- private fun updateSaveButton(currentName: String, currentUrl: String) {
+ private fun updateSaveButton() {
// Get the text from the edit texts.
- val newName = nameEditText.text.toString()
- val newUrl = urlEditText.text.toString()
+ val newName = bookmarkNameEditText.text.toString()
+ val newUrl = bookmarkUrlEditText.text.toString()
// Has the favorite icon changed?
- val iconChanged = webpageFavoriteIconRadioButton.isChecked
+ val iconChanged = !currentIconRadioButton.isChecked
// Has the name changed?
val nameChanged = newName != currentName
projects / PrivacyBrowserAndroid.git / blobdiff