]> gitweb.stoutner.com Git - PrivacyBrowserAndroid.git/commitdiff
Add a ripple touch animation to the New Tab and Close Tab buttons. https://redmine...
authorSoren Stoutner <soren@stoutner.com>
Thu, 4 Jul 2019 23:54:12 +0000 (16:54 -0700)
committerSoren Stoutner <soren@stoutner.com>
Thu, 4 Jul 2019 23:54:12 +0000 (16:54 -0700)
app/build.gradle
app/src/main/res/layout/main_framelayout.xml
app/src/main/res/values-es/strings.xml

index ec728bb4bf3eb133d805c1217919af0c691d37c6..3b8c832a71d94387ae7afcc59c86314ba66a8b5b 100644 (file)
@@ -86,5 +86,5 @@ dependencies {
     implementation 'com.google.android.material:material:1.0.0'
 
     // Only compile Firebase ads for the free flavor.
-    freeImplementation 'com.google.firebase:firebase-ads:17.2.1'
+    freeImplementation 'com.google.firebase:firebase-ads:18.0.0'
 }
\ No newline at end of file
index a381b996ddb0468b796660f4292a82571339fcde..5e330e2418fa072ab8fcf19e12a86f4949565d83 100644 (file)
                         app:layout_scrollFlags="scroll|enterAlways|snap"
                         android:visibility="gone" >
 
+                        <!-- `android:background="?attr/selectableItemBackground"` adds a ripple animation on touch. -->
                         <ImageView
-                            android:layout_height="wrap_content"
+                            android:layout_height="match_parent"
                             android:layout_width="wrap_content"
                             android:layout_gravity="center_vertical"
                             android:paddingStart="10dp"
                             android:paddingEnd="10dp"
                             android:src="@drawable/close_light"
                             android:tint="?attr/addTabIconTintColor"
+                            android:background="?attr/selectableItemBackground"
                             android:onClick="closeTab"
                             android:contentDescription="@string/close_tab" />
 
                             app:tabIndicatorGravity="top"
                             app:tabMode="scrollable" />
 
+                        <!-- `android:background="?attr/selectableItemBackground"` adds a ripple animation on touch. -->
                         <ImageView
-                            android:layout_height="wrap_content"
+                            android:layout_height="match_parent"
                             android:layout_width="wrap_content"
                             android:layout_gravity="center_vertical"
                             android:paddingStart="10dp"
                             android:paddingEnd="10dp"
                             android:src="@drawable/add_light"
                             android:tint="?attr/addTabIconTintColor"
+                            android:background="?attr/selectableItemBackground"
                             android:onClick="addTab"
                             android:contentDescription="@string/add_tab" />
                     </LinearLayout>
index c475ead2883acacf6d6f76bc1a1f157f1109146a..3790cb0cfad34388c01cc785e19b9a52409fb12c 100644 (file)
 
     <!-- Save Webpage as Image. -->
     <string name="save_image">Guardar imagen</string>
-    <string name="webpage_png">Webpage.png</string>
+    <string name="webpage_png">PaginaWeb.png</string>
     <string name="saving_image">Guardando imagen…</string>
     <string name="image_saved">Imagen guardada.</string>
     <string name="error_saving_image">Error guardando imagen:</string>